From owner-cvs-all Wed Jun 10 20:52:42 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id UAA10464 for cvs-all-outgoing; Wed, 10 Jun 1998 20:52:42 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from dyson.iquest.net (dyson.iquest.net [198.70.144.127]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA10337; Wed, 10 Jun 1998 20:52:09 -0700 (PDT) (envelope-from dyson@dyson.iquest.net) Received: (from root@localhost) by dyson.iquest.net (8.8.8/8.8.8) id WAA12373; Wed, 10 Jun 1998 22:51:25 -0500 (EST) (envelope-from dyson) Message-Id: <199806110351.WAA12373@dyson.iquest.net> Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vnops.c In-Reply-To: <199806110341.NAA08128@godzilla.zeta.org.au> from Bruce Evans at "Jun 11, 98 01:41:40 pm" To: bde@zeta.org.au (Bruce Evans) Date: Wed, 10 Jun 1998 22:51:25 -0500 (EST) Cc: cvs-committers@FreeBSD.ORG, julian@FreeBSD.ORG From: "John S. Dyson" Reply-To: dyson@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk Bruce Evans said: > > Modified files: > > sys/ufs/ffs ffs_vnops.c > > Log: > > Back out John's changes 1.45 -> 1.46 > > Kirk confirms that the original semantic was what he wanted... > > (well, a very slight difference) > > May fix "dangling deps" panic with soft updates. > > > > Revision Changes Path > > 1.50 +17 -21 src/sys/ufs/ffs/ffs_vnops.c > > A back out would have been +12 -17. > > It also seems to change the semantic to "wait for v_numoutput even in > the soft updates case", and fix some style bugs, and break the > optimization of using vfs_bio_awrite() instead of bawrite() for async > writes of indirect blocks. > If vfs_bio_awrite optimization is broken for *just* indirect blocks, there isn't much lossage. If the vfs_bio_awrite is broken for data blocks, the performance loss is significant. -- John | Never try to teach a pig to sing, dyson@freebsd.org | it just makes you look stupid, jdyson@nc.com | and it irritates the pig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message