Date: Fri, 13 Apr 2007 19:39:16 +0800 From: "Rong-en Fan" <grafan@gmail.com> To: "Gerald Pfeifer" <gerald@pfeifer.com> Cc: Andy Fawcett <andy@athame.co.uk>, freebsd-ports@freebsd.org Subject: Re: Generating INDEX Message-ID: <6eb82e0704130439w40d38a80h69d059b26c8189d3@mail.gmail.com> In-Reply-To: <Pine.LNX.4.64.0704130820460.32062@acrux.dbai.tuwien.ac.at> References: <461E1CC8.7090606@adestra.com> <200704121918.21307.andy@athame.co.uk> <6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com> <Pine.LNX.4.64.0704130820460.32062@acrux.dbai.tuwien.ac.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/13/07, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Fri, 13 Apr 2007, Rong-en Fan wrote: > > I think it's because lang/gcc41, gcc42's usage of USE_GNOME is incorrect. > > It should be > > > > WANT_GNOME= yes > > > > .include <bsd.port.pre.mk> > > > > USE_GNOME+= > > > > And our INDEX builder is i386, so we don't see this. > > Thanks for the report and the diagnosis. I'm away from a machine where > I can do a reasonable FreeBSD test/commit. > > Would the patch below address the issue? If so, anybody feel free to > commit to the lang/gcc41 and lang/gcc42 ports! > > (Now, there is a huge problem with this: The idea behind the original > changes was to use OPTIONS for these ports. Alas OPTIONS are processed > in bsd.port.mk.pre so their WITH/WITHOUT settings are available only after > bsd.port.mk. If we have to define WANT_GNOME before bsd.port.mk.pre, the > result of OPTIONS is not available yet. Does this mean we cannot sensibly > use OPTIONS for optional dependencies like this?) No, the patch won't work. According to http://www.freebsd.org/gnome/docs/porting.html, the right way is always define WANT_GNOME which won't pull any gnome dependencies unless USE_GNOME is used. I think after USE_PERL5_BUILD line, add WANT_GNOME=yes and use += for USE_GNOME after bsd.port.pre.mk Regards, Rong-En Fan > Gerald > > Index: Makefile > =================================================================== > RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v > retrieving revision 1.318 > diff -u -3 -p -r1.318 Makefile > --- Makefile 10 Apr 2007 05:24:27 -0000 1.318 > +++ Makefile 13 Apr 2007 06:24:29 -0000 > @@ -34,6 +34,9 @@ USE_BZIP2= yes > USE_GMAKE= yes > USE_ICONV= yes > USE_PERL5_BUILD=yes > +.if defined(WITH_JAVA_AWT) > +WANT_GNOME= yes > +.endif > > PATCH_WRKSRC= ${SRCDIR} > CONFIGURE_SCRIPT= ../${SRCDIR:C/${WRKDIR}//}/configure >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6eb82e0704130439w40d38a80h69d059b26c8189d3>