Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 May 2015 08:22:51 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Mathieu Arnold <mat@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r385216 - head/devel/tcllib
Message-ID:  <mw1k-7tfo-wny@FreeBSD.org>
In-Reply-To: <201505022018.t42KIT7q073232@svn.freebsd.org> (Mathieu Arnold's message of "Sat, 2 May 2015 20:18:29 %2B0000 (UTC)")
References:  <201505022018.t42KIT7q073232@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Mathieu Arnold <mat@FreeBSD.org> writes:

> Author: mat
> Date: Sat May  2 20:18:29 2015
> New Revision: 385216
> URL: https://svnweb.freebsd.org/changeset/ports/385216
>
> Log:
>   Fixup USE_GITHUB usage.
[...]
> @@ -17,8 +17,7 @@ OPTIONS_DEFINE=3D	DOCS MANPAGES
>=20=20
>  USE_GITHUB=3D	yes
>  GH_ACCOUNT=3D	tcltk
> -GH_PROJECT=3D	tcllib
> -GH_COMMIT=3D	4c7af4c
> +GH_TAGNAME=3D	${PORTNAME}_${PORTVERSION:S/./_/}

Why duplicate version in distinfo? This goes against Porter's Handbook
"slight variation from PORTREVISION" example of using DISTVERSION*FIX.

Index: devel/tcllib/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- devel/tcllib/Makefile	(revision 385376)
+++ devel/tcllib/Makefile	(working copy)
@@ -2,7 +2,8 @@
 # $FreeBSD$
=20
 PORTNAME=3D	tcllib
=2DPORTVERSION=3D	1.17
+DISTVERSIONPREFIX=3D${PORTNAME}_
+DISTVERSION=3D	1_17
 CATEGORIES=3D	devel tcl
=20
 MAINTAINER=3D	tcltk@FreeBSD.org
@@ -17,7 +18,6 @@ OPTIONS_DEFINE=3D	DOCS MANPAGES
=20
 USE_GITHUB=3D	yes
 GH_ACCOUNT=3D	tcltk
=2DGH_TAGNAME=3D	${PORTNAME}_${PORTVERSION:S/./_/}
=20
 USES+=3D		tcl
 GNU_CONFIGURE=3D	yes
Index: devel/tcllib/distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- devel/tcllib/distinfo	(revision 385376)
+++ devel/tcllib/distinfo	(working copy)
@@ -1,2 +1,2 @@
=2DSHA256 (tcltk-tcllib-1.17-tcllib_1_17_GH0.tar.gz) =3D cbfbad79314e752f63=
b78227a2a33e91fba1ebcabe3b69fa8d1ee6b235125043
=2DSIZE (tcltk-tcllib-1.17-tcllib_1_17_GH0.tar.gz) =3D 8284201
+SHA256 (tcltk-tcllib-tcllib_1_17_GH0.tar.gz) =3D cbfbad79314e752f63b78227a=
2a33e91fba1ebcabe3b69fa8d1ee6b235125043
+SIZE (tcltk-tcllib-tcllib_1_17_GH0.tar.gz) =3D 8284201

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQF8BAEBCgBmBQJVRxA7XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bfEEIAJ3Vs4KPe4wX7Twq9+y8pjs6
CxvrKMPQgEtpCk8NIRI5QkAkw1t70Rg6kKYzNAw3IwSKr1WCbtVeTNoZ26PmK5fG
M+pZId3pDIpwf1ORHNKmM71vK580jRjDci2/IZYhELZTvH8TJwrOofrwTyIlS463
eReXxDe+6W7EEsL2tov2ZVq1nt7Qz4WwaIL1qXuOGN7nZTx3jZBGQ4d8qT4/NNzU
VQMRIJGvoanMsuiH4Hi+2m6AZe6hj9Lv3KbViXx09esoGPQ2jux6IWyHPqriWzb/
ylgGOFvJJEb30kqVNo13wKJITOsnk5JFVEHYdFg7vHeI6pO0Zj6IML0pglzrv8A=
=Y+NH
-----END PGP SIGNATURE-----
--=-=-=--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?mw1k-7tfo-wny>