From owner-cvs-all Mon Mar 18 13:23:58 2002 Delivered-To: cvs-all@freebsd.org Received: from gw.nectar.cc (gw.nectar.cc [208.42.49.153]) by hub.freebsd.org (Postfix) with ESMTP id 7D60937B402; Mon, 18 Mar 2002 13:23:52 -0800 (PST) Received: from madman.nectar.cc (madman.nectar.cc [10.0.1.111]) by gw.nectar.cc (Postfix) with ESMTP id E44E14C; Mon, 18 Mar 2002 15:23:51 -0600 (CST) Received: (from nectar@localhost) by madman.nectar.cc (8.11.6/8.11.6) id g2ILNnD29147; Mon, 18 Mar 2002 15:23:49 -0600 (CST) (envelope-from nectar) Date: Mon, 18 Mar 2002 15:23:49 -0600 From: "Jacques A. Vidrine" To: cjclark@alum.mit.edu Cc: Shin-ichi YOSHIMOTO , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c pw_copy.c pw_copy.h Message-ID: <20020318212349.GA29060@madman.nectar.cc> Mail-Followup-To: "Jacques A. Vidrine" , cjclark@alum.mit.edu, Shin-ichi YOSHIMOTO , Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200203180222.g2I2Ms309830@freefall.freebsd.org> <20020318161250.1c35600c.yosimoto@waishi.jp> <20020318170348.671ec4b5.yosimoto@waishi.jp> <20020318001922.Z29705@blossom.cjclark.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020318001922.Z29705@blossom.cjclark.org> User-Agent: Mutt/1.3.27i X-Url: http://www.nectar.cc/ Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Mar 18, 2002 at 12:19:22AM -0800, Crist J. Clark wrote: > chpass(8) is very, very naughty and uses __pw_scan(). The underscores are a warning that it is being naughty. In this case, I was not ready to commit to an API for `pw_scan', so when it needed to be moved to libc, I hid it. I meant to revisit the issue one day, but so it goes. Do not rename it unless you intend for it to be a public API that will be maintained across releases. And don't forget to document it in that case. [snip] > This isn't an issue in -STABLE, where pw_scan() is exposed to the > world properly in libc. No, it's not. There is no pw_scan in -STABLE's libc. Cheers, -- Jacques A. Vidrine http://www.nectar.cc/ NTT/Verio SME . FreeBSD UNIX . Heimdal Kerberos jvidrine@verio.net . nectar@FreeBSD.org . nectar@kth.se To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message