Date: Wed, 22 Sep 2004 11:30:07 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Brooks Davis <brooks@one-eyed-alien.net> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c Message-ID: <20040922153007.GA91347@green.homeunix.org> In-Reply-To: <20040922150105.GA17806@odin.ac.hmc.edu> References: <200409220859.i8M8xgwb022928@repoman.freebsd.org> <20040922130052.GA3407@green.homeunix.org> <20040922150105.GA17806@odin.ac.hmc.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote: > On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wrote: > > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote: > > > brooks 2004-09-22 08:59:42 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/net if.c > > > Log: > > > Fix a LOR where ifconf() used copyout while holding a mutex. This LOR > > > was seen when configuring addresses on interfaces using ifconfig. This > > > patch has been verified to work with over eight thousand addresses > > > assigned to an interface. > > > > > > LOR id: 031 > > > > You really need to be running with INVARIANTS if you plan on committing > > kernel code, or people are likely to get angry when their systems crash > > for stupid reasons. > > Sorry about that. Pass the pointy had please. :-( No hard feelings, since I'm used to having a new issue or two every kernel upgrade, but this really should be a lesson to anyone listening that kernel development without INVARIANTS (and sometimes WITNESS) is a big no-no. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040922153007.GA91347>