From owner-svn-src-all@freebsd.org Mon May 20 19:32:10 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01C6715901AD; Mon, 20 May 2019 19:32:10 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 942F78EF3C; Mon, 20 May 2019 19:32:09 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f41.google.com with SMTP id g16so11975960iom.9; Mon, 20 May 2019 12:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=u5QCbIA0nXMtc8i21bv+SrovCA7M3bJ8x8NyEEFQyOc=; b=s7f8Ifk8TvRK8QgXe/bn//UvqzP58Zpoa6P0v6wkmlZrfZ1Z9RzRnuh5H7HnDukUBR ZMZklREGl41UdFomz9W4sBktXhMQwnJ69kLQjApLI7TAYxo08xNPluS9OJD8PLETnfU9 g8Es/Jao2fmzJqHJbftkmRpr/Vy0H4RbYxnYaSB4KPI5LEKOkF2Ni0V88JdvaS4F3ZdK fWStNWJNkCabQPzaC7I+9hhEtH8ORzQy/3LDGGmTYE2HVddTLt4MNi7SkOlpfLVOULaG JKv3+fiAB4L3e9/LKHxYQocx8M4N6NXiSJUfklEdKRG6czdIvMt3K4A1t3JA8ctNyWM5 YveA== X-Gm-Message-State: APjAAAUUjlS22GclpR2WWTGmr8QznaqCqfAV0FshvAUpNYbeEb4QqDWM olAeEWN7fC9s3VWUpfvBE6uK4r+T X-Google-Smtp-Source: APXvYqyrGMzVNAC8tuzRcD5sDOmWXibRwZGJUOqFKEmZbysPi8BOTRP9uYipL2B+DkGqnkeHykEuwA== X-Received: by 2002:a6b:c945:: with SMTP id z66mr40841963iof.191.1558380723182; Mon, 20 May 2019 12:32:03 -0700 (PDT) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com. [209.85.166.52]) by smtp.gmail.com with ESMTPSA id t63sm151153ita.42.2019.05.20.12.32.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 12:32:02 -0700 (PDT) Received: by mail-io1-f52.google.com with SMTP id g84so12004417ioa.1; Mon, 20 May 2019 12:32:02 -0700 (PDT) X-Received: by 2002:a6b:c411:: with SMTP id y17mr9717396ioa.265.1558380722801; Mon, 20 May 2019 12:32:02 -0700 (PDT) MIME-Version: 1.0 References: <201905200038.x4K0cNoZ019920@repo.freebsd.org> <20190520192047.GA3524@server.rulingia.com> In-Reply-To: <20190520192047.GA3524@server.rulingia.com> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Mon, 20 May 2019 12:31:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra12... To: Peter Jeremy Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 942F78EF3C X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.97)[-0.968,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2019 19:32:10 -0000 Hi Peter, Thanks for reporting this. I ran a full tinderbox on this change (many many tinderboxes) and am not sure how I missed this. I have to run to an appointment now, but will fix these in a couple hours if no one else beats me to it. The fix is straightforward =E2=80=94 include . Best, Conrad On Mon, May 20, 2019 at 12:21 PM Peter Jeremy wrote: > > On 2019-May-20 00:38:23 +0000, Conrad Meyer wrote: > >Author: cem > >Date: Mon May 20 00:38:23 2019 > >New Revision: 347984 > >URL: https://svnweb.freebsd.org/changeset/base/347984 > > > >Log: > > Extract eventfilter declarations to sys/_eventfilter.h > ... > > No functional change (intended). Of course, any out of tree modules t= hat > > relied on header pollution for sys/eventhandler.h, sys/lock.h, or > > sys/mutex.h inclusion need to be fixed. __FreeBSD_version has been bu= mped. > > This seems to have broken at least netmap and netdump for me: > /usr/src/sys/dev/netmap/netmap_freebsd.c:191:3: error: implicit declarati= on of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wimplici= t-function-declaration] > EVENTHANDLER_REGISTER(ifnet_arrival_event, > ^ > ... > /usr/src/sys/netinet/netdump/netdump_client.c:1458:22: error: implicit de= claration of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-W= implicit-function-declaration] > nd_detach_cookie =3D EVENTHANDLER_REGISTER(ifnet_departur= e_event, > ^ > > -- > Peter Jeremy