From owner-freebsd-bugs@FreeBSD.ORG Fri Dec 31 09:20:27 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE11916A4CE for ; Fri, 31 Dec 2004 09:20:27 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9767D43D41 for ; Fri, 31 Dec 2004 09:20:27 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBV9KR80034005 for ; Fri, 31 Dec 2004 09:20:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBV9KRPi034004; Fri, 31 Dec 2004 09:20:27 GMT (envelope-from gnats) Date: Fri, 31 Dec 2004 09:20:27 GMT Message-Id: <200412310920.iBV9KRPi034004@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Bjoern A. Zeeb" Subject: Re: kern/75677: [patch] sk(4): plug leaks and fix acquiringduplicate lock of same type: "network driver" X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: "Bjoern A. Zeeb" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Dec 2004 09:20:27 -0000 The following reply was made to PR kern/75677; it has been noted by GNATS. From: "Bjoern A. Zeeb" To: Antoine Brodin Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: kern/75677: [patch] sk(4): plug leaks and fix acquiring duplicate lock of same type: "network driver" Date: Fri, 31 Dec 2004 09:12:45 +0000 (UTC) On Fri, 31 Dec 2004, Antoine Brodin wrote: > A patch that fixes some of them is attached, but there is probably more > leaks. > Especially mii_phy_probe() and miibus_probe() allocate things during > a probe routine without freeing them and I suspect it's bad. a patch[1] for mii already exists for the parts that are not specific to sk(4) (but this is outside of this PR). [1] http://sources.zabbadoz.net/freebsd/patchset/mii-memleaks.diff