Date: Wed, 12 Apr 2023 17:41:14 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Muhammad Moinur Rahman <bofh@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: <lmmqulsh7aanq57y2iynkqrxqd7t7zrp23qoz5ydmrbjv33n3l@cedf5cs7irvg> In-Reply-To: <ZDa%2BdPM7qCMgDeRs@FreeBSD.org> References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <ZDa1j/k5bMGxfDH0@FreeBSD.org> <6inj2unwo45zfdu65na77yeob7pteqy62gdrxganabcagk3pjc@tvkxg2g773o3> <ZDa%2BdPM7qCMgDeRs@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--xctndhbry7x5kehy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 12, 2023 at 02:21:40PM +0000, Alexey Dokuchaev wrote: > On Wed, Apr 12, 2023 at 03:55:00PM +0200, Mathieu Arnold wrote: > > On Wed, Apr 12, 2023 at 01:43:43PM +0000, Alexey Dokuchaev wrote: > > > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrot= e: > > > > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > > >=20 > > > > lang/php8[12]: Fix build on aarch64 with ZTS > > > >=20 > > > > - Refresh patches > > >=20 > > > What good did it bring other than cloaking the actual fix with tons > > > of needless, unrelated changes? You've poured a glass of honey into > > > a bucket of tar. :( > >=20 > > Because that is something you have to do everytime a port is updated, >=20 > No, you don't, and you shouldn't. Patches come and go all the time, > blindly following this "rule" just brings useless noise to the commit > diff, nothing else. >=20 > > refresh the patches so that the line offsets are correct wrt current > > sources, to make sure patch(1) can just apply the patches and not > > resort to guesswork. >=20 > If patch(1) cannot apply some patch, it will complain and the port > won't build, so existing patches are applicable by definition. >=20 > But we have already argued about this in the past. I prefer cleaner > commit diffs, you don't, oh well. I don't care about the commit diff of patches, really, patches of patches are mostly unreadable. On the other hand, we, as a group, care about patches that are correct, not patches that happen to apply, maybe at the correct place, by the grace of some random heuristic in patch(1). Please stop badgering committers about rules you decided on your own and that only apply for you. I would also add something along the lines of "please follow our policies" but we both know you will not. --=20 Mathieu Arnold --xctndhbry7x5kehy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmQ20RlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb5PWQv/a3xIAxkjHJntmKoOoJmytPduLUsx2O/hQ3GT67rmD+fPWuYIEwYG5cOW tJrLxppNitKMDpgSp/w3KgxoBxU2/3PiskxM/NX4QNidvjRf+eEr/KlmmNUivo0Z Lp8RWpCMDhwgi6y4fWkOmVoPx8rM123W11Gy9pKU2mZasrG9FiPOOVGXCHlPcThl rV4IVzGFvlhb1cs1PxPXSrfrHYqvxwQ9KVLWOSikhUr0Xh3tMiPczPWQbrRS4/Xl aRrPQd/v06tF11aniZOHMJxX+WZ+/pR9Uk5Fj5q3XZfzJKWCg7Qtbjd8F6gKZmFl c4VNVLfDEjmAEOxYANuADNuwvqoyOwig/E3hSuj7qRK2weI3ByuMqcrJSi1f5cmT mfyrHmlQF9jZR8ZhviHLm5T2jm2IjiD1tOuHfThHcVfGyinDYxCpe017Y2ycxBzV wRnsUU27EYKAPuZybPpK31y8SXrrdDCV2hl4vQlQZjF2y1q3EyOAf8krpyr248Lz qXGpm88l =6l/w -----END PGP SIGNATURE----- --xctndhbry7x5kehy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?lmmqulsh7aanq57y2iynkqrxqd7t7zrp23qoz5ydmrbjv33n3l>