From owner-cvs-sys  Tue Oct  7 21:08:12 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id VAA16293
          for cvs-sys-outgoing; Tue, 7 Oct 1997 21:08:12 -0700 (PDT)
          (envelope-from owner-cvs-sys)
Received: from implode.root.com (implode.root.com [198.145.90.17])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id VAA16248;
          Tue, 7 Oct 1997 21:07:24 -0700 (PDT)
          (envelope-from root@implode.root.com)
Received: from implode.root.com (localhost [127.0.0.1])
	by implode.root.com (8.8.5/8.8.5) with ESMTP id VAA16426;
	Tue, 7 Oct 1997 21:09:14 -0700 (PDT)
Message-Id: <199710080409.VAA16426@implode.root.com>
To: Bill Fenner <fenner@FreeBSD.ORG>
cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/netinet tcp_output.c 
In-reply-to: Your message of "Tue, 07 Oct 1997 14:10:07 PDT."
             <199710072110.OAA00816@freefall.freebsd.org> 
From: David Greenman <dg@root.com>
Reply-To: dg@root.com
Date: Tue, 07 Oct 1997 21:09:14 -0700
Sender: owner-cvs-sys@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>fenner      1997/10/07 14:10:06 PDT
>
>  Modified files:
>    sys/netinet          tcp_output.c 
>  Log:
>  Don't allow the window to be increased beyond what is possible to
>  represent in the TCP header.  The old code did effectively:
>  	win = min(win, MAX_ALLOWED);
>  	win = max(win, what_i_think_i_advertised_last_time);
>  so if what_i_think_i_advertised_last_time is bigger than can be
>  represented in the header (e.g. large buffers and no window scaling)
>  then we stuff a too-big number into a short.  This fix reverses the
>  order of the comparisons.

   This should be brought into 2.2-stable as well. Bill?

-DG

David Greenman
Core-team/Principal Architect, The FreeBSD Project