Date: Tue, 9 Aug 2022 18:15:13 +0000 From: Glen Barber <gjb@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: Mark Millard <marklmi@yahoo.com>, Warner Losh <imp@bsdimp.com>, "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, FreeBSD Hackers <freebsd-hackers@freebsd.org>, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: Looks like the arm 20220805 snapshots are still odd, so probably kern.geom.part.mbr.enforce_chs=0 was still in use Message-ID: <20220809181513.GG30607@FreeBSD.org> In-Reply-To: <CAPyFy2AfGxgND-2KaPUy8RnS6MYaxQBnGDPBkz9vDhLekNN%2BbQ@mail.gmail.com> References: <6AF28022-A8E7-46B3-B64E-99D217E9B6AC@yahoo.com> <0E0083BD-A749-4112-8FDA-62326EA95F8A@freebsd.org> <CAPyFy2AfGxgND-2KaPUy8RnS6MYaxQBnGDPBkz9vDhLekNN%2BbQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--JO68zLCmjMElvUWJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Aug 09, 2022 at 02:06:14PM -0400, Ed Maste wrote:
> On Sun, 7 Aug 2022 at 18:43, Glen Barber <gjb@freebsd.org> wrote:
> >
> > Will do. I=E2=80=99ll commit the suggested change to main tomorrow.
> >
> > Thank you for your vigilant investigation.
>=20
> Shall I commit the enforce_chs check now?
> ---
> commit 6ee7d69e6b526f35789b23ba570025f1c3b39c1a
> Author: Ed Maste <emaste@FreeBSD.org>
> Date: Tue Jul 19 16:47:49 2022 -0400
>=20
> release: ensure enforce_chs sysctl is 0
>=20
> We do not want CHS-based alignment for VM or SD card release images.
>=20
> Sponsored by: The FreeBSD Foundation
>=20
> diff --git a/release/tools/arm.subr b/release/tools/arm.subr
> index 6e4ae731a0b9..01c5303cd4e1 100644
> --- a/release/tools/arm.subr
> +++ b/release/tools/arm.subr
> @@ -62,6 +62,10 @@ umount_loop() {
> }
>=20
> arm_create_disk() {
> + if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) !=3D 0 ]; then
> + return 1
> + fi
> +
> # Create the target raw file and temporary work directory.
> chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev}
> if [ "${PART_SCHEME}" =3D "GPT" ]; then
>=20
Good question. Do we still want to ensure it is set to '0'? I'm a bit
confused from the back-and-forth on the original thread.
If we do want to ensure it is set to '0', yes, please go ahead.
Glen
--JO68zLCmjMElvUWJ
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAmLypCwACgkQAxRYpUeP
4pPj4A//fpME+l0kRIO41QC6b/TFUDVGi7cNITaNjYr27uaqKVyub9A1Hx4OlUuj
VpIZhjm7zmvdscd02HZKqg5LiZyNopH2fd4Y9pXvFBoUamBqX6QwYzUlPN6WKkEF
wXwcquYFZ355F3fN/2iJTkyvMEbhzcHRods+IupJkOC0Lbfxg4hXkv/9Ro2nEw0D
uITxwgpfQUL9v/l7D+gd7XL/6HRY+Hx8s4LUt4GZDMqEWZX9r5d1GUHEZAEu3AWf
yWuFMDsxygI3U2n+zrSG9L+kDEKKAzrORGVfDiAkN5Y/kIkSueitZer0Wyk0Kf+W
InhZvFZZvfBBRw0b5ZUWQRoNXVrSydRFEAKrxOvh1uaC3WTZuc44lJVttuL0wLIW
6m2lJU9hvGJSYwv9xd3lwak9JXjYIfc0GhrpvPjIYaIQdUL7ahsvExJrSvlWYlm+
Ncil0a32gb0uwPJQPxFwdpH9DUmukJd2JfeenSIoaNYFWsUD6pJ2o9oIsNrTr4ZE
ffDK+0qFhS2dQfshZwK/E4GNBinLeuJPsBBr5/dVUC2LIs3glYUwcTpkwNiLZZAS
v/Qrt6ytjXwmjAvD2Xt2FU9Fvn1/44Uc/+5p0WG52g0W76Dbw3PIsknHoTKzMlE+
9EpQBP2bR6ca8eWz4qiaGxBb+LtDEGsHwMsknRcaU820h3JXvYA=
=Rsh+
-----END PGP SIGNATURE-----
--JO68zLCmjMElvUWJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220809181513.GG30607>