From owner-freebsd-current Wed Jun 19 22:15:35 2002 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id CF45237B404; Wed, 19 Jun 2002 22:15:31 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g5K5DhIj075766; Thu, 20 Jun 2002 07:13:43 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Juli Mallett Cc: Bruce Evans , "Greg 'groggy' Lehey" , current@FreeBSD.ORG Subject: Re: HEADSUP: UFS2 patch coming... In-Reply-To: Your message of "Wed, 19 Jun 2002 21:55:13 PDT." <20020619215513.A90131@FreeBSD.ORG> Date: Thu, 20 Jun 2002 07:13:42 +0200 Message-ID: <75759.1024550022@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >> I think about half of the patch should be committed separately. phk has >> already committed some related things separately, but not nearly half. > >I seem to recall seeing whitespace changes, dead code removal, and api changes >which are not exclusive to ufs2 and would do well to be abstracted, but I did >not have the time earlier to go over and annotate these so I decided not to >mention it. But anyway. Well, I suggest you tell the author of the patch that, since I'm only the messenger in this case: kirk@mckusick.com -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message