From owner-freebsd-current@FreeBSD.ORG Tue Feb 24 07:42:19 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5B36116A4CF for ; Tue, 24 Feb 2004 07:42:19 -0800 (PST) Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id 33D3343D41 for ; Tue, 24 Feb 2004 07:42:19 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 12993 invoked from network); 24 Feb 2004 15:42:18 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 24 Feb 2004 15:42:18 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i1OFgE28037356; Tue, 24 Feb 2004 10:42:14 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: current@FreeBSD.org Date: Tue, 24 Feb 2004 10:43:38 -0500 User-Agent: KMail/1.6 References: <200402241527.i1OFRC7E074338@gw.catspoiler.org> In-Reply-To: <200402241527.i1OFRC7E074338@gw.catspoiler.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200402241043.38696.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: kuriyama@imgsrc.co.jp cc: Don Lewis cc: freebsd-current@FreeBSD.org cc: mat@cnd.mcgill.ca cc: cg@FreeBSD.org Subject: Re: exclusive sleep mutex pcm0 (sound cdev) r = 0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2004 15:42:19 -0000 On Tuesday 24 February 2004 10:27 am, Don Lewis wrote: > On 24 Feb, Jun Kuriyama wrote: > > I got this warning on my current box: > > > > malloc() of "256" with the following non-sleepable locks held: > > exclusive sleep mutex pcm0 (sound cdev) r = 0 (0xc73e63c0) locked @ > > dev/sound/pcm/dsp.c:213 > > > > I think there is no need to wait in vchan_create(). If kernel does > > not have resources to return small 256 bytes memory for sound device, > > we are not in the situation to care whether sound is played correctly > > or not... > > There are a bunch more problems with the "sound cdev" mutex, many of > which can't be fixed by this type of change unless having sporadic sound > system failures due to temporary malloc() failures is acceptable. > > I currently have some patches for the channel mutexes that are > undergoing testing. Once these have been committed, I'll take another > look at the "sound cdev" mutex. My current thought is to convert most > uses of it to a lockmgr lock. Eek, why not a sx lock if you must go to a sleepable lock? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org