From owner-freebsd-stable Wed Jun 6 21:50:50 2001 Delivered-To: freebsd-stable@freebsd.org Received: from david.siemens.de (david.siemens.de [192.35.17.14]) by hub.freebsd.org (Postfix) with ESMTP id CD49237B405 for ; Wed, 6 Jun 2001 21:50:43 -0700 (PDT) (envelope-from andre.albsmeier@mchp.siemens.de) X-Envelope-Sender-Is: andre.albsmeier@mchp.siemens.de (at relayer david.siemens.de) Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by david.siemens.de (8.11.0/8.11.0) with ESMTP id f574oN526704; Thu, 7 Jun 2001 06:50:24 +0200 (MET DST) Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7]) by mail1.siemens.de (8.11.0/8.11.0) with ESMTP id f574oM709886; Thu, 7 Jun 2001 06:50:22 +0200 (MET DST) Received: (from localhost) by curry.mchp.siemens.de (8.11.3/8.11.3) id f574oMu50483; Date: Thu, 7 Jun 2001 06:50:22 +0200 From: Andre Albsmeier To: John Polstra Cc: stable@freebsd.org, ohartman@klima.physik.uni-mainz.de, andre.albsmeier@mchp.siemens.de Subject: Re: NIS/YP still broken! Message-ID: <20010607065022.A89754@curry.mchp.siemens.de> References: <200106062047.f56KlZB44913@vashon.polstra.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106062047.f56KlZB44913@vashon.polstra.com>; from jdp@polstra.com on Wed, Jun 06, 2001 at 01:47:35PM -0700 X-Echelon: BND CIA NSA Mossad KGB MI6 IRA detonator nuclear assault strike Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 06-Jun-2001 at 13:47:35 -0700, John Polstra wrote: > In article , > Hartmann, O. wrote: > > :>> > FreeBSD 4.3-STABLE has still a broken NIS/YP! If there are more than > > :>> > one slave servers ypxfrd should spread its tables, push seems to > > :>> > lock up and get a timeout. > > :>> > > > :>> > This was reported earlier here and I got a 'fix' for this but this fix > > :>> > hasn't been merged in due it targets a sypmtome, not the cause itself. > [...] > > Well, this problem occurs on ALL systems running here and configured as > > NIS/YP server and running the recent FreeBSD 4.3-STABLE. It should be > > able to reproduce the problem! > > Offline I have been working with Andre Albsmeier on this problem. > Andre gave me a detailed description of what he has discovered and > observed, as well as a recipe for reproducing the bug. Unfortunately, > the recipe didn't make the bug appear for me. I think it must fail > only in Germany. :-) That's really curious... > HOWEVER, based on what Andre told me, I inspected the relevant code > in yppush_main.c. I am pretty sure I have found the bug. There > is a struct sigaction on the stack which is not fully initialized; > in particular, the sa_flags member is uninitialized. It contains > whatever garbage was on the stack, and that garbage would be > influenced by many things, including the actions of the dynamic > linker. Furthermore, certain flag bits such as SA_RESETHAND, if set, > would cause exactly the symptoms you guys have described. > > Please apply the patch below to "/usr/src/usr.sbin/yppush/yppush_main.c" > and let me know if it fixes the problem. The patch is relative to > -stable. Yes, it does :-). Only three words compared to the history this issue had now... Lots of thanks, John, -Andre > > Thanks, > John > > > Index: yppush_main.c > =================================================================== > RCS file: /home/ncvs/src/usr.sbin/yppush/yppush_main.c,v > retrieving revision 1.11 > diff -u -r1.11 yppush_main.c > --- yppush_main.c 1999/08/28 01:21:09 1.11 > +++ yppush_main.c 2001/06/06 20:26:12 > @@ -651,6 +651,7 @@ > sigaddset(&sa.sa_mask, SIGALRM); > sigaddset(&sa.sa_mask, SIGINT); > sa.sa_handler = async_handler; > + sa.sa_flags = 0; > > sigaction(SIGIO, &sa, NULL); > -- FreeBSD-4.3: Another day closer to a Micro$oft free world To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message