From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 16:07:56 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 541B2106569D; Wed, 22 Oct 2008 16:07:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id D8D038FC1E; Wed, 22 Oct 2008 16:07:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m9MG7dq6017965; Wed, 22 Oct 2008 12:07:46 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Alexander Leidinger Date: Wed, 22 Oct 2008 11:19:01 -0400 User-Agent: KMail/1.9.7 References: <200810211851.m9LIptwg006141@svn.freebsd.org> <200810211702.21348.jhb@freebsd.org> <20081022114359.19407gtt68cj7aww@webmail.leidinger.net> In-Reply-To: <20081022114359.19407gtt68cj7aww@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810221119.01902.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 22 Oct 2008 12:07:47 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8468/Wed Oct 22 08:35:20 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, Scott Long , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r184135 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2008 16:07:56 -0000 On Wednesday 22 October 2008 05:43:59 am Alexander Leidinger wrote: > Quoting John Baldwin (from Tue, 21 Oct 2008 17:02:21 -0400): > > >> John Baldwin wrote: > > >> > --- head/sys/dev/ata/ata-dma.c Tue Oct 21 18:50:52 2008 (r184134) > >> > +++ head/sys/dev/ata/ata-dma.c Tue Oct 21 18:51:55 2008 (r184135) > >> > @@ -78,7 +78,7 @@ ata_dmainit(device_t dev) > >> > ch->dma.unload = ata_dmaunload; > >> > ch->dma.alignment = 2; > >> > ch->dma.boundary = 65536; > >> > - ch->dma.segsize = 63536; > >> > + ch->dma.segsize = 65536; > > > This was only in HEAD though since the SATA port multiplier changes. > > Can this be the reason for "acd0: FAILURE - non aligned DMA transfer > attempted" messages when trying to play a DVD with xine? I don't think so as that printf is in the ATA code before it does a bus_dmamap_load(), and this bug just caused busdma to split up some ATA DMA requests into more scatter/gather entries than truly necessary. -- John Baldwin