From nobody Sat Oct 14 16:47:00 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S78RT1tW4z4x0k6 for ; Sat, 14 Oct 2023 16:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S78RT0dTbz4Lsv for ; Sat, 14 Oct 2023 16:47:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697302021; a=rsa-sha256; cv=none; b=mX5UADtHMWNNexO2PUkcyMwuy62l8Y/CtppTsc7yJhNjBAdOFH76oLMbhWIjPy/9hR9IqB j2AX69CkwE+kik0mCOyftNTVbtNtn5X6sXV/GXzaHCOo0s2eUWtmeIfDMtMU1uV2Oi/0td s7IdgmPCeWH54qsz2lWHqnnhVvhjG7tE2No4EGIKMbTJGYKRrwkWgdMYKohGmkVNOXcbfI tIsnKCG9HN5dLte6HWsK73L4O6Z7LcPB2gAYBZxdiCFj5+3fkXBpao37SbwEg/e/YunOCD 7Wznq7dJHm5qCNOWZtPOcezCFV6r3zr/Dsmm2J7gpvbgMV1QeUc5E1h9lq9ZiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697302021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ru39nTc4lpC1flOb139m4gP6qihzBIk+dSc1pwW92y4=; b=O30eXAOO7cAEUa2xTGo/fa8iInK7ojqkjSlITlRmkof/vri7NbJR0ln23iba2T1S4aMZce IZstOpFxdioTRkw3BVSOmPyA5GA20UBSQEQ9SseFyPR7rmN12JMD0fCtEay/nF9MSeLbGh 6JK1yEqI2ntpyZ3cSEeCKZSJlHNM1Sj1FZubxfKxE1k+GQYwYyLCpUW25rztx7aZWMLfQw MOBLkCEvm5CBm9uCRBlBxNMyiwLkXWOPU2pE3PDDqt6qGCOfMyRxl1CRbg+w77aWGI1SjG RrjcXvNmOkEse2iRr4cc0EsV1QW+XZzTkAAyJCd/30q9eQTD+bNKnhLicGgVmA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S78RS6k8WzdrN for ; Sat, 14 Oct 2023 16:47:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39EGl0Ds047010 for ; Sat, 14 Oct 2023 16:47:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39EGl0kt047009 for bugs@FreeBSD.org; Sat, 14 Oct 2023 16:47:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 274454] usr.sbin/syslogd: closing a configured terminal in parse_action(), line 3057 Date: Sat, 14 Oct 2023 16:47:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jake@technologyfriends.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274454 Jake Freeland changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake@technologyfriends.net --- Comment #3 from Jake Freeland --- (In reply to Trond Endrest=C3=B8l from comment #0) Hi Trond, I'm not really sure what you mean by "made /dev/ttyvb inactive". A TTY descriptor is only opened in parse_action() to check whether it is a valid tty using isatty(). That descriptor is closed because it will never be accessed again. See https://cgit.freebsd.org/src/tree/usr.sbin/syslogd/syslogd.c?id=3Da5ed6a815= e38d6c622cd97a6020592ded579cf7a#n1973 When a log message is sent to a TTY, its path (saved in f->fu_fname) is pas= sed into ttymsg() and used to reopen the TTY under a new, temporary descriptor. That original descriptor value (f->f_file) is never actually used. Did your patch fix the issue you were facing? If so, there is something I am not seeing here. --=20 You are receiving this mail because: You are the assignee for the bug.=