From owner-freebsd-current@freebsd.org Sat Jan 9 04:49:45 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A0FEA6937E for ; Sat, 9 Jan 2016 04:49:45 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) by mx1.freebsd.org (Postfix) with ESMTP id 22901157F; Sat, 9 Jan 2016 04:49:44 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id HlTBa2ffIpK8XHlTCaCfVX; Fri, 08 Jan 2016 21:49:43 -0700 X-Authority-Analysis: v=2.1 cv=IaYnITea c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=BWvPGDcYAAAA:8 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=VxmjJ2MpAAAA:8 a=kj9zAlcOel0A:10 a=7aQ_Q-yQQ-AA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=ksRbnbemZReF5x0I4AwA:9 a=CjuIK1q_8ugA:10 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 4442E13751; Fri, 8 Jan 2016 20:49:41 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id u094ndp0091994; Fri, 8 Jan 2016 20:49:40 -0800 (PST) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201601090449.u094ndp0091994@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Adrian Chadd cc: Jeremie Le Hen , Ryan Stone , FreeBSD Current , =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= Subject: Re: Panic from vesa_configure() In-Reply-To: Message from Cy Schubert of "Thu, 07 Jan 2016 17:07:46 -0800." <201601080107.u0817kDw078603@slippy.cwsent.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 08 Jan 2016 20:49:39 -0800 X-CMAE-Envelope: MS4wfJGGwO1pa7h86yu9NMDHnuAWooKXByDLzb0bO6mFDa47B7dDGId/YMg+7uoEPDMUnKVDh44I1EkPNUQSwnvEpSI2RpwgZBwyciN0ikVslkr6dDeVVTzj tVjqTF/KaKKDHdcllww+DlisO+U5qGp73WmQQ8wJR5EopLXVPdfMMzIVrjka1wlel4ExoaUCXB8Zn6vc81M3rM/E6QG/435z734jSlBE2qrUb41hV8FHIwGv z+uK5ihn7/QTLuz+DwvuqFb7yMx/bdhdK9KyRLpCxZd/VPU2OSWYoE6uuKwoV577KN+zgG7F34x2n66V+4IjrA== X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2016 04:49:45 -0000 In message <201601080107.u0817kDw078603@slippy.cwsent.com>, Cy Schubert writes: > In message om> > , Adrian Chadd writes: > > Ok, > > > > So try adding this check: > > > > vmbuf = x86bios_alloc(&offs, sizeof(*buf), M_WAITOK); > > if (vmbuf == NULL) { > > printf("%s: x86bios_alloc failed!\n", __func__); > > goto fail; > > } > > > > ... that call shouldn't be failing, but if it's truely failing on the > > bcopy(), the only reason is because vmbuf is NULL. > > Thanks. I'll try this. > > vesa.c hasn't changed for a while so I suspect the root cuase may be > somewhere else (we're probably treating the symptom here). Nice thing about > using the same mobo and cpu combination on all my machines (except > laptops), failures are completely reproducible. Might be a good idea to put > in a dtrace probe too. Hi Adrian, Your patch fixed the issue. I've included a dtrace probe. I suspect the error may be BIOS specific and the dtrace probe should help in tracking it down. Does this look good to commit? -- Cheers, Cy Schubert or FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.