From owner-freebsd-toolchain@FreeBSD.ORG Fri Sep 26 14:52:33 2014 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88B6ACF5; Fri, 26 Sep 2014 14:52:33 +0000 (UTC) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57C607AA; Fri, 26 Sep 2014 14:52:32 +0000 (UTC) Received: from [92.247.20.226] (port=1327 helo=[172.16.19.1]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82) (envelope-from ) id 1XXWsp-0003Px-6W; Fri, 26 Sep 2014 10:52:31 -0400 From: "George Neville-Neil" To: "Mark Johnston" Subject: Re: WITH_CTF vs -g Date: Fri, 26 Sep 2014 17:52:24 +0300 Message-ID: <47C2BB52-E2DB-45B2-B6E1-3D05DAEFE32F@neville-neil.com> In-Reply-To: <20140925225142.GC2501@ip-172-31-25-62.ec2.internal> References: <54108909.7050908@FreeBSD.org> <20140925225142.GC2501@ip-172-31-25-62.ec2.internal> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=_MailMate_5AB27897-19E1-4FA4-AD53-58C31E8A8A55_="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Mailer: MailMate (1.8r4469) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com Cc: freebsd-toolchain@FreeBSD.org, freebsd-dtrace@FreeBSD.org, Andriy Gapon X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Sep 2014 14:52:33 -0000 This is an OpenPGP/MIME signed message (RFC 3156 and 4880). --=_MailMate_5AB27897-19E1-4FA4-AD53-58C31E8A8A55_= Content-Type: text/plain On 26 Sep 2014, at 1:51, Mark Johnston wrote: > On Wed, Sep 10, 2014 at 08:23:21PM +0300, Andriy Gapon wrote: >> >> In my opinion WITH_CTF should imply -g in CFLAGS otherwise, as far as I can see, >> there is nothing to generate CTF data from. Forcing an end-user to remember to >> additionally pass -g is not nice. >> >> Also, I think that we can always have -g in CTFFLAGS, because the stripping step >> takes care of the original DWARF data in any case. But I am not 100% sure about >> this. >> >> What do you think? >> Thanks! > > Hi Andriy, > > Are you planning to go through with this? I was just about to post this > exact question, but then I remembered that you already have. :) > > FWIW, the diff I have in mind is below. It also removes some checks that > I think are unnecessary from bsd.{lib,prog}.mk. It is not fully tested, > but seems to work for me. I'm also not sure about unconditionally > passing -g to ctfconvert and ctfmerge. > Mark, Can you put this up in Phabricator? reviews.freebsd.org Best, George > Thanks, > -Mark > > diff --git a/share/mk/bsd.lib.mk b/share/mk/bsd.lib.mk > index f0acf16..c6b689d 100644 > --- a/share/mk/bsd.lib.mk > +++ b/share/mk/bsd.lib.mk > @@ -36,7 +36,7 @@ NO_WERROR= > .if defined(DEBUG_FLAGS) > CFLAGS+= ${DEBUG_FLAGS} > > -.if ${MK_CTF} != "no" && ${DEBUG_FLAGS:M-g} != "" > +.if ${MK_CTF} != "no" > CTFFLAGS+= -g > .endif > .else > diff --git a/share/mk/bsd.own.mk b/share/mk/bsd.own.mk > index 486914b..32556a1 100644 > --- a/share/mk/bsd.own.mk > +++ b/share/mk/bsd.own.mk > @@ -128,6 +128,7 @@ ____: > > .if ${MK_CTF} != "no" > CTFCONVERT_CMD= ${CTFCONVERT} ${CTFFLAGS} ${.TARGET} > +DEBUG_FLAGS?= -g > .elif defined(.PARSEDIR) || (defined(MAKE_VERSION) && ${MAKE_VERSION} >= 5201111300) > CTFCONVERT_CMD= > .else > diff --git a/share/mk/bsd.prog.mk b/share/mk/bsd.prog.mk > index 340950a..e4f7104 100644 > --- a/share/mk/bsd.prog.mk > +++ b/share/mk/bsd.prog.mk > @@ -20,7 +20,7 @@ NO_WERROR= > CFLAGS+=${DEBUG_FLAGS} > CXXFLAGS+=${DEBUG_FLAGS} > > -.if ${MK_CTF} != "no" && ${DEBUG_FLAGS:M-g} != "" > +.if ${MK_CTF} != "no" > CTFFLAGS+= -g > .endif > .endif > _______________________________________________ > freebsd-dtrace@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace > To unsubscribe, send any mail to "freebsd-dtrace-unsubscribe@freebsd.org" --=_MailMate_5AB27897-19E1-4FA4-AD53-58C31E8A8A55_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEUEARECAAYFAlQlfagACgkQYdh2wUQKM9J8jACeKY01jUvP0JfdM2puK0ma8gyC YC0AmL8Jvyeb2cPVUMWJE8zUKuHvuPE= =08RQ -----END PGP SIGNATURE----- --=_MailMate_5AB27897-19E1-4FA4-AD53-58C31E8A8A55_=--