From owner-freebsd-ports Wed Mar 6 15:32:53 1996 Return-Path: owner-ports Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id PAA09702 for ports-outgoing; Wed, 6 Mar 1996 15:32:53 -0800 (PST) Received: from veda.is (veda.is [193.4.230.1]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id PAA09690 for ; Wed, 6 Mar 1996 15:32:46 -0800 (PST) Received: (from adam@localhost) by veda.is (8.7.4/8.7.3) id XAA06695; Wed, 6 Mar 1996 23:32:30 GMT From: Adam David Message-Id: <199603062332.XAA06695@veda.is> Subject: Re: PATCH_PRFX in bsd.port.mk To: asami@cs.berkeley.edu (Satoshi Asami) Date: Wed, 6 Mar 1996 23:32:29 +0000 (GMT) Cc: ports@freebsd.org In-Reply-To: <199603062221.OAA01200@sunrise.cs.berkeley.edu> from Satoshi Asami at "Mar 6, 96 02:21:27 pm" X-Mailer: ELM [version 2.4ME+ PL10 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-ports@freebsd.org Precedence: bulk > Ok. I was considering adding a new variable for putting all files > (distfiles + patchfiles) in a subdirectory. Currently some ports just > get around this by defining ${DISTDIR} = ${PORTSDIR}/distfiles/. > > Is it ok if I take out all the PATCH_PRFX hacks and replace it with > something like > > DISTDIR ?= ${PORTSDIR}/distfiles/${DISTDIR_PRFX}/ This looks like a very good idea, simple, elegant and even more generic. DISTDIR_SUFX or DISTFILES_SUBDIR would probably be a better variable name, I prefer the latter. > It won't do any renaming, but putting them in a subdirectory should be > good enough. Since they will all be grouped together in a unique subdir, there is less need for renaming. The main reason that I wanted to enable renaming was to avoid situations where a port with very few additional files (with unclear names) would require a subdirectory. Putting the main distfile in the subdirectory is fine by me, but I do have some aversion to seeing files with very long names residing in directories which are named almost identically to the file. :) I'll get over it... ;) -- Adam David