From owner-svn-src-all@FreeBSD.ORG Tue Apr 14 10:28:38 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81713106564A; Tue, 14 Apr 2009 10:28:38 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id 02F8B8FC0A; Tue, 14 Apr 2009 10:28:37 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-107-120-227.carlnfd1.nsw.optusnet.com.au (c122-107-120-227.carlnfd1.nsw.optusnet.com.au [122.107.120.227]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n3EAS9vh002186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 14 Apr 2009 20:28:13 +1000 Date: Tue, 14 Apr 2009 20:28:09 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Ed Schouten In-Reply-To: <20090413161812.GD32098@hoeg.nl> Message-ID: <20090414202138.O53192@delplex.bde.org> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090413161812.GD32098@hoeg.nl> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: Revert unneeded changes of r190919 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2009 10:28:38 -0000 On Mon, 13 Apr 2009, Ed Schouten wrote: > Because the changes in r190919 did contain some nice fixes, but some of > them were unneeded or should not attempted to be fixed here, I've > decided to prepare a commit to revert the changes made in r190919, > except the improvements Christoph made to the inline assembly. > > http://80386.nl/pub/cmallon.diff Review of what I can quote easily in mail: this url appears to be syntactically correct. This is OK, but I would prefer to use temporary hacks in machdep.c than to mess up cpufunc.h with macros. Temporary until machdep.c is done right. In one right version, a file other than machdep.c would provide all the functions in cpufunc.h as extern functions callable by ddb, and _all_ the functions in cpufunc.h certainly shouldn't be messed up with macros. Bruce