From owner-freebsd-arch@FreeBSD.ORG Thu Jan 17 06:30:16 2008 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5836716A417; Thu, 17 Jan 2008 06:30:16 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from mx-out-01.forthnet.gr (mx-out.forthnet.gr [193.92.150.104]) by mx1.freebsd.org (Postfix) with ESMTP id C3F7513C45B; Thu, 17 Jan 2008 06:30:15 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from mx-av-01.forthnet.gr (mx-av.forthnet.gr [193.92.150.27]) by mx-out-01.forthnet.gr (8.13.8/8.13.8) with ESMTP id m0H4Rveu018397; Thu, 17 Jan 2008 06:27:57 +0200 Received: from MX-IN-03.forthnet.gr (mx-in-05.forthnet.gr [193.92.150.32]) by mx-av-01.forthnet.gr (8.14.1/8.14.1) with ESMTP id m0H4RvEg027531; Thu, 17 Jan 2008 06:27:57 +0200 Received: from kobe.laptop (ppp176-5.adsl.forthnet.gr [62.1.179.5]) by MX-IN-03.forthnet.gr (8.14.2/8.14.2) with ESMTP id m0H4RotA002829; Thu, 17 Jan 2008 06:27:51 +0200 Authentication-Results: MX-IN-03.forthnet.gr smtp.mail=keramida@freebsd.org; spf=permerror Authentication-Results: MX-IN-03.forthnet.gr header.from=keramida@freebsd.org; sender-id=permerror Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.2/8.14.2) with ESMTP id m0H4Rn4M001708; Thu, 17 Jan 2008 06:27:49 +0200 (EET) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.2/8.14.2/Submit) id m0H4RmfM001707; Thu, 17 Jan 2008 06:27:48 +0200 (EET) (envelope-from keramida@freebsd.org) Date: Thu, 17 Jan 2008 06:27:48 +0200 From: Giorgos Keramidas To: Andre Oppermann Message-ID: <20080117042747.GA1617@kobe.laptop> References: <20071219123305.Y95322@fledge.watson.org> <47693DBD.6050104@swin.edu.au> <476A45D6.6030305@freebsd.org> <47858D35.6060006@swin.edu.au> <4786D23A.1080509@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4786D23A.1080509@freebsd.org> Cc: James Healy , Lawrence Stewart , net@freebsd.org, Robert Watson , arch@freebsd.org Subject: Re: Coordinating TCP projects X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2008 06:30:16 -0000 On 2008-01-11 03:19, Andre Oppermann wrote: >Lawrence Stewart wrote: >>> I've got a rewritten and much more efficient tcp_reass() function in >>> my local tree. I'll import it into Perforce next week with all the >>> other stuff. You may want to base your auto-sizing work on it. The >>> only missing parts are some statistics gathering. >> >> Where abouts is this code? A cursory browse through the Perforce web >> front-end reveals nothing. We're going to start work on the TCP >> reassembly queue autotuning patch now and if you think we should base >> it on your new tcp_reass() we need to have a look at it. > > The first cut is now at //depot/projects/tcp_reass/ however I made a > mistake when creating the branch and now the code is in the same > changeset as the branching itself. Doesn't make it easy to do a diff. > Have to see how I can fix that. Anyway, have a look and I'm going to > finish/fix the code tomorrow evening. Hi Andre, You can `p4 obliterate' the branch and recommit. Alternatively, you can commit a second change, with the clean branch-origin source, and then re-commit the tcp_reass code. The perforce-admins may have a preferred way of fixing this, so it's probably worth asking too. HTH, Giorgos