From nobody Tue Nov 23 15:03:15 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DA63618883D5; Tue, 23 Nov 2021 15:03:15 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hz6pC4pzNz4mmZ; Tue, 23 Nov 2021 15:03:15 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637679795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ac75Ql+MC6e3Ybp2anU5fq0Bks7toQLUs8wASAhGENE=; b=qOZP5Vcsfi7xE3lUw3tAZMt4o5Y19rPIcqrFEuI0YfGAsM/1ilXrjVU4O40kBqpa9aecAH G5twXRYl/OQ6p78BlNBySjYb/1wZmA7XnI+Re8qVoIZzpBvXO0rcAqxMn2OUslEG3mjEs7 YVyD1iX09buljtlJu22CqGQBZgd7u6sni1dOjjIvnaNl5lmmVAb+k0A8+g/HEL8UIWW9VY S5gAi1vk975DUj0wDzBAayAVpnkrogWkbh9Ftvev6AoQ0WEsAtThq3xxOXmC0rQQidCBus LSjz8oyNWTmpD4eH+MWkCsbF94GjqOFVbAUKEBY5dM2/rANEgDitgZhjrXbKHw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4ADC531C3; Tue, 23 Nov 2021 15:03:15 +0000 (UTC) Date: Tue, 23 Nov 2021 15:03:15 +0000 From: Alexey Dokuchaev To: Olivier Cochard Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 50119a0b4317 - main - net-im/telegram-desktop: Cleanup and set new maintainer Message-ID: References: <202111171708.1AHH81SP093799@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637679795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ac75Ql+MC6e3Ybp2anU5fq0Bks7toQLUs8wASAhGENE=; b=ddUhW1VbYNjXfUex//UXNKQLXunAKDe0Uqd83d6OXGVSjXXQYHFBcQOaDH49yawzBZLHA/ i6S0ryv5A46Ko4ycy69FsSO5qQWPsZkvYc/Y5glVQJa9BMwZRdg7TFdlPgIpxtq4tL79Xx XGxsLQnWHbdwvTvbuSfz7bg5dWdtQVH0uaBsH4IQIwsWFZ6rR9ciEKRrXlUeW1g3/eMBq6 eTC5NpKeuovjJsgTsLiq+4aZ7pDPmjjkDGhhxSHlRzoJXppo4Tus6A6LYGV9dC14TyoHyJ 97SG03jSqyKsDV1sWIwtlZRD1QVJaCC/NwSDPsAasDJv3DMpOOqGCyZ2Z9wIvQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637679795; a=rsa-sha256; cv=none; b=ASW0dJNdPj90Awo/b+uAQFZOiGsqBwZaewFuFxln4/9ESXhFa6NUCEm/6HdFNz+uhz3RzT 6svrGz89siq4d8Rc8cZl8G/Mm1oZRR02iMb014z5g938InDkTwUoXC9att3nb9+kAqOW68 DaGnhxnl8ZiHvbu7BrkQ7vXRr2moVernvSQDZVEnXkMjCkOeyHdZQ8eQO9ktIUUrP9OpG1 BdOpOEMlmyUwNlDaoqgTcRfOs1fMxO+l5zNmjXg3kG/LMxIgzK7Lj3RYYRmafZOWWMBc/y dmus4DVk4nAP39ORoqhq3tCtWGah1Ip8qu49pJmcdSiz7B8xQN/iT4M63w3MFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Ping? On Thu, Nov 18, 2021 at 01:59:08AM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 17, 2021 at 05:08:01PM +0000, Olivier Cochard wrote: > > commit 50119a0b431718d00a22f424a550239246021ff9 > > > > net-im/telegram-desktop: Cleanup and set new maintainer > > > > Reported by: glebius > > Sorry, I don't understand, what exactly was "reported" here? This > looks more like a patch submission committed without maintainer > approval. > > > -CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_RLOTTIE DESKTOP_APP_USE_PACKAGED_VARIANT \ > > - DESKTOP_APP_USE_GLIBC_WRAPS TDESKTOP_USE_PACKAGED_TGVOIP \ > > - DESKTOP_APP_USE_PACKAGED_FONTS > > +CMAKE_OFF= DESKTOP_APP_USE_PACKAGED_FONTS > > These vars being dropped from CMAKE_OFF should've been explained. > > > +INSTALLS_ICONS= yes > > + > > Please see the latest CHANGES entry 20211010. > > > -.if ${CHOSEN_COMPILER_TYPE} == clang && ${COMPILER_VERSION} <= 100 > > -post-patch: > > - @${REINPLACE_CMD} -e '/-fstack-clash-protection/d' ${WRKSRC}/cmake/options_linux.cmake > > +.if ${COMPILER_VERSION} < 120 > > +LLVM_VER= 12 > > +BUILD_DEPENDS+= clang${LLVM_VER}:devel/llvm${LLVM_VER} > > +CC= ${LOCALBASE}/bin/clang${LLVM_VER} > > +CXX= ${LOCALBASE}/bin/clang++${LLVM_VER} > > Pulling in non-default LLVM port is hardly a "cleanup" and also deserves > a proper explanation; so does removing those patches. > > ./danfe