From nobody Tue Apr 4 10:31:53 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrPFp0JTsz43Lt7; Tue, 4 Apr 2023 10:31:58 +0000 (UTC) (envelope-from yuri@aetern.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrPFn5RbVz45T2; Tue, 4 Apr 2023 10:31:57 +0000 (UTC) (envelope-from yuri@aetern.org) Authentication-Results: mx1.freebsd.org; none Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 2A72D5C0165; Tue, 4 Apr 2023 06:31:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 04 Apr 2023 06:31:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aetern.org; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1680604317; x=1680690717; bh=a1cD1xd7RKuj2I/qIeG3KzvI2Za9qV/74N3 0hRGeps4=; b=w348+HAHaGP17NtPW7M3B7FyHWSUXu9XezieXfPQ9VeWn0LhXaC I6nT/cyJwFzPWz8SgdpcMUoTCFtnMA/BcfEXD5yNQ7qQfqtnf63qqSVI4LkPoBH0 TMNzX7n3ZpbiP+KGF4T/4BIaa3gm+VB9538zZGwwEYgXB0tH4nBexLXs0mSi4YZb /DQ51wFwtS16QTz6QkLF6863mUADrWvRtNCnFy48QznoqWoHGbDD3VSu4L/PASxs AfZBrwlu3TuPM7g9JAp3slG+zs2IhTL06ZQH1RlyvLK0T+FRL9cXHC32aUtPCXG4 JXjJi7rzhptpBjE0LSw8YanSPYdIEup6umA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680604317; x=1680690717; bh=a1cD1xd7RKuj2I/qIeG3KzvI2Za9qV/74N3 0hRGeps4=; b=vtQaHi/80QA0xQYaIFG1HVXcCPKnP4k3UJR6zgJiCjfOkSLav0d L3bKvV1lSkpB3mm92oTB1W6VF5WcR1GLQY38vkiKzCCVlwpaCErdLCeyjmlw448s 2kjqwdp5nakO2llJGOsLK96aO3CbJpaVLsO1RUkhlhdDvhaG9WPe1K4T1+rPUzXf dW8nOJNXqn3U4I71FUipZCK4NUWgMZyxiN7OYDayaC284YKR2ORwKYwLDPuXR33b kRew1ZKzU7Eh9T+WBQS/N+zO+B/TuIeN2iLRV8se34x8BXzuTU13GDdqxk2ZCFFN nPCv5JhNJlphe/EDl1bq1uHejzl4Bwd+L7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiledgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhr ihcuoeihuhhrihesrggvthgvrhhnrdhorhhgqeenucggtffrrghtthgvrhhnpeektdffie eiieegjefgffeigfevjeefvdetjedtieeugffgleeifeevhfevffehteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihesrggvthgvrh hnrdhorhhg X-ME-Proxy: Feedback-ID: i0d79475b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 Apr 2023 06:31:55 -0400 (EDT) Message-ID: <872bff80-a306-a5b8-dbc1-cf54be85fa81@aetern.org> Date: Tue, 4 Apr 2023 12:31:53 +0200 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: git: 643336549081 - main - If copy_file_range(2) fails with EXDEV, use fall-back. To: Mateusz Guzik , Poul-Henning Kamp Cc: Alexey Dokuchaev , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202304040740.3347eiU8033699@gitrepo.freebsd.org> <202304040959.3349xqqB005509@critter.freebsd.dk> <202304041015.334AF7oF006042@critter.freebsd.dk> Content-Language: en-US From: Yuri In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4PrPFn5RbVz45T2 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N Mateusz Guzik wrote: > On 4/4/23, Poul-Henning Kamp wrote: >> -------- >> Alexey Dokuchaev writes: >> >>> Okay, but did it leave an empty file, I wonder? >> >> I didn't check, but it probably would, because cp(1) must have opened >> and created the destination in order to call copy_file_range(2). >> >> PS: I'll note that EXDEV is not a documented return value from >> copy_file_range(2), and my surprise that cp(1) did not revert >> to the fall-back, no matter why copy_file_range(2) failed. >> > > that's a new one and should not be happening, something is borked in > the kernel -- cross device copies *are* supported > > i'll look into it later Likely has to do with openzfs merge issues reported by Cy just above?