From owner-cvs-all Sun Jun 2 7:27: 8 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 9116C37B405; Sun, 2 Jun 2002 07:27:03 -0700 (PDT) Received: (from brian@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g52ER3E21691; Sun, 2 Jun 2002 07:27:03 -0700 (PDT) (envelope-from brian) Message-Id: <200206021427.g52ER3E21691@freefall.freebsd.org> From: Brian Somers Date: Sun, 2 Jun 2002 07:27:03 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/ppp radius.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG brian 2002/06/02 07:27:03 PDT Modified files: usr.sbin/ppp radius.c Log: Don't send a RAD_NAS_IP_ADDRESS attribute as RAD_NAS_IDENTIFIER is sufficient. In fact, using both breaks the radiator RADIUS daemon when used with a db as it maps both attributes to the same field value and then fails the insert. I decided to remove RAD_NAS_IP_ADDRESS on the basis that rfc2138 says: An Access-Request MUST contain a User-Name attribute. It SHOULD contain either a NAS-IP-Address attribute or NAS-Identifier attribute (or both, although that is not recommended). It MUST despite the fact that this not recommended bit was removed from the updated rfc. Revision Changes Path 1.28 +8 -0 src/usr.sbin/ppp/radius.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message