From owner-freebsd-ports@FreeBSD.ORG Sat Aug 21 13:18:50 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 54A7916A4CE for ; Sat, 21 Aug 2004 13:18:50 +0000 (GMT) Received: from fillmore.dyndns.org (port-212-202-50-15.dynamic.qsc.de [212.202.50.15]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0784143D31 for ; Sat, 21 Aug 2004 13:18:50 +0000 (GMT) (envelope-from eikemeier@fillmore-labs.com) Received: from dhcp-8.local ([172.16.0.8] helo=dhcp-10.local) by fillmore.dyndns.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.41 (FreeBSD)) id 1ByVlf-0000GH-Pq; Sat, 21 Aug 2004 15:18:49 +0200 Date: Sat, 21 Aug 2004 15:18:48 +0200 Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v482) To: "ports/c0decafe.net" From: Oliver Eikemeier In-Reply-To: <1093092893.90622.110.camel@atlantis.local> Message-Id: Content-Transfer-Encoding: 7bit User-Agent: KMail/1.5.9 cc: Clement Laforet cc: freebsd-ports@freebsd.org Subject: Re: PREFIX-safe installation of apache modules [Was: FreeBSD ports which are currently scheduled for deletion] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Aug 2004 13:18:50 -0000 ports/c0decafe.net wrote: > I can see that now, in the sense that i assumed a user's point of view > while the real/actual concern/problem was much more elaborated. Jup. I mostly see the packages as something that I want to test and build, and someone else would use. Supporting this is important when you want to do QA work on the ports tree. >> Which reminds me that we should honor this scenario in the apxs patch. > > instead of patching apxs, maybe using it's -S switch (overwriting a > given variable) would help here? The problem is that the modules Makefiles use apxs, and not necessarily use the do-install from Makefile.modules.3rd. I have no problem with tailoring build tools to FreeBSD specific needs, we all run modified gcc versions, libtool, perl and many other things. When we decide this is the right behaviour on FreeBSD, it's fine. [...] > + @${ECHO} "@cwd ${PREFIX}" > ${PLIST} No, you already are in ${PREFIX}. Every @cwd breaks pkg_add -p and should only used when absolutely necessary (or better not at all). > do-install: > - @${APXS} -i -A -n ${SHORTMODNAME} > ${WRKSRC}/${MODULENAME}.${AP_BUILDEXT} > + APXS_LIBEXEC!= ${APXS} -q LIBEXECDIR You shouldn't do this in a target, and please avoid the use of != wherever possible. You'll spawn a process for every tool that does a make(1) in the directory, even when the information is totally irrelevat (INDEX builds, FreshPorts, chkversion, ...). Besides it breaks the INDEX when APXS is not installed. Rule of thumb: don't use !=. > + @${APXS} -S LIBEXEC=${PREFIX}${APXS_LIBEXEC:S/${APXS_PREFIX}//} -i > -A -n ${SHORTMODNAME} ${WRKSRC}/${MODULENAME}.${AP_BUILDEXT} As said above: this won't help when the module port uses apxs directly. -Oliver