From owner-svn-src-head@freebsd.org  Thu Apr 19 15:16:12 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03A25F82DA2;
 Thu, 19 Apr 2018 15:16:12 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6D70B6A593;
 Thu, 19 Apr 2018 15:16:11 +0000 (UTC)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1])
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w3JFG92M066372;
 Thu, 19 Apr 2018 08:16:09 -0700 (PDT)
 (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net)
Received: (from freebsd@localhost)
 by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w3JFG99V066371;
 Thu, 19 Apr 2018 08:16:09 -0700 (PDT) (envelope-from freebsd)
From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
Message-Id: <201804191516.w3JFG99V066371@pdx.rh.CN85.dnsmgr.net>
Subject: Re: svn commit: r332773 - head/etc/rc.d
In-Reply-To: <201804191502.w3JF2sgQ051472@repo.freebsd.org>
To: Kyle Evans <kevans@freebsd.org>
Date: Thu, 19 Apr 2018 08:16:09 -0700 (PDT)
CC: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Reply-To: rgrimes@freebsd.org
X-Mailer: ELM [version 2.4ME+ PL121h (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Apr 2018 15:16:12 -0000

> Author: kevans
> Date: Thu Apr 19 15:02:53 2018
> New Revision: 332773
> URL: https://svnweb.freebsd.org/changeset/base/332773
> 
> Log:
>   Fix ddb rc script
>   
>   r288291 added a call to limits(1), which isn't available before partitions
>   are mounted. This broke the ddb rc script, which does not provide its own
>   start_cmd.
>   
>   Alleviate the situation here by providing a start_cmd. We still have other
>   problems with diskless setups that need to be considered, but this is a
>   start.

Thanks,
Also didn't cy identify a second one of these?
Or am I confusing yet another issue?

>   PR:		206291
>   Submitted by:	cy
>   Discussed with:	rgrimes
>   MFC after:	3 days
> 
> Modified:
>   head/etc/rc.d/ddb
> 
> Modified: head/etc/rc.d/ddb
> ==============================================================================
> --- head/etc/rc.d/ddb	Thu Apr 19 15:02:42 2018	(r332772)
> +++ head/etc/rc.d/ddb	Thu Apr 19 15:02:53 2018	(r332773)
> @@ -15,6 +15,7 @@ desc="DDB kernel debugger"
>  rcvar="ddb_enable"
>  command="/sbin/${name}"
>  start_precmd="ddb_prestart"
> +start_cmd="ddb_start"
>  stop_cmd=":"
>  
>  ddb_prestart()
> @@ -23,6 +24,11 @@ ddb_prestart()
>  	if [ -z "`sysctl -Nq debug.ddb.scripting.scripts`" ]; then
>  		return 1
>  	fi
> +}
> +
> +ddb_start()
> +{
> +	${command} ${command_args}
>  }
>  
>  load_rc_config $name
> 
> 

-- 
Rod Grimes                                                 rgrimes@freebsd.org