From owner-freebsd-arch@FreeBSD.ORG Wed Sep 6 21:06:32 2006 Return-Path: X-Original-To: arch@freebsd.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 982F916A4E0 for ; Wed, 6 Sep 2006 21:06:32 +0000 (UTC) (envelope-from prvs=julian=39777be4f@elischer.org) Received: from a50.ironport.com (a50.ironport.com [63.251.108.112]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4F31C43D5D for ; Wed, 6 Sep 2006 21:06:32 +0000 (GMT) (envelope-from prvs=julian=39777be4f@elischer.org) Received: from unknown (HELO [10.251.18.229]) ([10.251.18.229]) by a50.ironport.com with ESMTP; 06 Sep 2006 14:06:31 -0700 Message-ID: <44FF3858.8070003@elischer.org> Date: Wed, 06 Sep 2006 14:06:32 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.13) Gecko/20060414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "M. Warner Losh" References: <20060905.215047.-494097326.imp@bsdimp.com> <20060905.220137.1973602740.imp@bsdimp.com> In-Reply-To: <20060905.220137.1973602740.imp@bsdimp.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: USB changes X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2006 21:06:32 -0000 M. Warner Losh wrote: >In message: <20060905.215047.-494097326.imp@bsdimp.com> > "M. Warner Losh" writes: >: The time has come to reduce the #ifdefs that have grown to infest the >: usb code. The other BSDs have already done this to a greater or >: lessor extent. Many of the #ifdef sections have decayed and no longer >: work on the target system. There's been a number of cases where bugs >: have resulted, and they generally make the code harder to read and >: understand. >: >: I'd like to remove many of the ifdefs, as well as expand many of the >: portability hacks that are there. I'll do my best to make sure that >: each of the changes bring the files closer to style(9) as well as not >: change the md5 of the .o file. >: >: Comments? > >Here's ugen.c that I've partially converted that retains the same md5 >for ugen.o when compiled as a module. > >Warner > > >------------------------------------------------------------------------ > >Index: ugen.c > I think the time has come.. go for it.