From owner-svn-src-head@freebsd.org Tue Oct 22 08:29:00 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F658154047; Tue, 22 Oct 2019 08:29:00 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46y69S1MTNz4TQd; Tue, 22 Oct 2019 08:28:59 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f175.google.com with SMTP id z2so4888963ybn.6; Tue, 22 Oct 2019 01:28:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hJl+PtRA18XzIvQvqvbNXkJdcbhldrxutFupXGUIXho=; b=K35zrO/KA9884lRJ2Y682t48FEDPW/BiwpD7ETXohGpiQfCSJ0nBv0GdFrfdzrrJaz KxN4Fqqrer/SNMeoL/6F0fq3z8waobjgX/g0WQ6MqIkFxWrc+mj7VyoFeMscjsslxATS ybUwPnasKNeberzBxWD5b367cZrVwHOL/DoZoMuwCd2WiF4ebcq9YFovcOhbULVheRkv 3hylGqVZfS9Owd72y+HLpG18CzM/W8WvQUJJXNVtyfuNhv2JLPXbrfpjy/pqaXBjXRrL ts5Z7ieQ0Ux5RdqWs1ucpZRt1ktGPk4Y0gMPj1/msFixC1YeqXYgGTS6hGF2Y7sFcJUU Xqag== X-Gm-Message-State: APjAAAV6fwk6H1CmHqEq04Xb5SF0QK5SxMMShsm669Aa3IO3/YwFeDb5 Kt5MoxPJzvy6+Iq4rr71quOwd0+Sgio2NqXYJgzHcFgg X-Google-Smtp-Source: APXvYqyL0xHdxNQgDSTpXb50tenyqsfKXf44npWJKmd2TaQifn/R2bkBrY5z4FC7Kh+E8u0xBRDP01pWMxxA9BiY/K8= X-Received: by 2002:a25:9087:: with SMTP id t7mr1518915ybl.451.1571732938347; Tue, 22 Oct 2019 01:28:58 -0700 (PDT) MIME-Version: 1.0 References: <201910212312.x9LNCEbX052414@repo.freebsd.org> In-Reply-To: <201910212312.x9LNCEbX052414@repo.freebsd.org> From: Li-Wen Hsu Date: Tue, 22 Oct 2019 16:28:45 +0800 Message-ID: Subject: Re: svn commit: r353876 - head/sys/kern To: Gleb Smirnoff Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46y69S1MTNz4TQd X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 08:29:00 -0000 On Tue, Oct 22, 2019 at 7:12 AM Gleb Smirnoff wrote: > > Author: glebius > Date: Mon Oct 21 23:12:14 2019 > New Revision: 353876 > URL: https://svnweb.freebsd.org/changeset/base/353876 > > Log: > Assert that any epoch tracker belongs to the thread stack. > > Reviewed by: kib > > Modified: > head/sys/kern/subr_epoch.c > > Modified: head/sys/kern/subr_epoch.c > ============================================================================== > --- head/sys/kern/subr_epoch.c Mon Oct 21 21:21:34 2019 (r353875) > +++ head/sys/kern/subr_epoch.c Mon Oct 21 23:12:14 2019 (r353876) > @@ -366,9 +366,13 @@ _epoch_enter_preempt(epoch_t epoch, epoch_tracker_t et > struct thread *td; > > MPASS(cold || epoch != NULL); > - INIT_CHECK(epoch); > MPASS(epoch->e_flags & EPOCH_PREEMPT); > td = curthread; > + MPASS((vm_offset_t)et >= td->td_kstack && > + (vm_offset_t)et + sizeof(struct epoch_tracker) < > + td->td_kstack + td->td_kstack_pages * PAGE_SIZE); > + > + INIT_CHECK(epoch); > #ifdef EPOCH_TRACE > epoch_trace_enter(td, epoch, et, file, line); > #endif Hello Gleb, RISC-V boot panics with this message: panic: Assertion (vm_offset_t)et >= td->td_kstack && (vm_offset_t)et + sizeof(struct epoch_tracker) < td->td_kstack + td->td_kstack_pages * PAGE_SIZE failed at /workspace/src/sys/kern/subr_epoch.c:373 Full log: https://ci.freebsd.org/job/FreeBSD-head-riscv64-test/12334/console Can you help check this? Thanks, Li-Wen