From owner-freebsd-current@FreeBSD.ORG Wed Apr 13 05:40:23 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4010A16A4CE for ; Wed, 13 Apr 2005 05:40:23 +0000 (GMT) Received: from mail26.sea5.speakeasy.net (mail26.sea5.speakeasy.net [69.17.117.28]) by mx1.FreeBSD.org (Postfix) with ESMTP id B900C43D49 for ; Wed, 13 Apr 2005 05:40:22 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 16298 invoked from network); 13 Apr 2005 05:40:22 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail26.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 13 Apr 2005 05:40:22 -0000 Received: from hydrogen.funkthat.com (cdsdyb@localhost.funkthat.com [127.0.0.1])j3D5eKGH002606; Tue, 12 Apr 2005 22:40:21 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j3D5eK6K002605; Tue, 12 Apr 2005 22:40:20 -0700 (PDT) Date: Tue, 12 Apr 2005 22:40:20 -0700 From: John-Mark Gurney To: Suleiman Souhlal Message-ID: <20050413054020.GL56487@funkthat.com> Mail-Followup-To: Suleiman Souhlal , current@FreeBSD.org References: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0842a01b5aa0cfcd84763fff4a30113e@FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: current@FreeBSD.org Subject: Re: [PATCH] Allow watching of vnodes that reside on non-UFS filesystems with kqueue X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Apr 2005 05:40:23 -0000 Suleiman Souhlal wrote this message on Tue, Apr 12, 2005 at 23:05 -0400: > Hello, > > The patch at > http://people.freebsd.org/~ssouhlal/testing/kqueue-hooks-20050412.diff > allows watching vnodes on non-UFS filesystems with kqueue. > > It moves the VN_KNOTE calls to pre and post VOP_* hooks. These hooks > are currently used for VFS lock debugging only, but I made them > unconditional. I think that they we could eventually move the > mac_check_vnode_* calls into them too, with a bit of work. > > I would like to commit this to HEAD, if there are no objections. I would prefer to move the vfs_kqfilter and filt_vfs* functions either be moved to a vfs specific file, or be moved to their own file.. also, it appears that we lost support for extending of files... though I can't confirm that... Have you verified that extending still gets notified? Other wise looks good... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."