From owner-freebsd-current@FreeBSD.ORG Thu Feb 26 08:45:30 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C9EF106567B; Thu, 26 Feb 2009 08:45:30 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211]) by mx1.freebsd.org (Postfix) with ESMTP id BE0258FC1C; Thu, 26 Feb 2009 08:45:29 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 8B1341CDE5; Thu, 26 Feb 2009 09:45:28 +0100 (CET) Date: Thu, 26 Feb 2009 09:45:28 +0100 From: Ed Schouten To: Andrew Thompson Message-ID: <20090226084528.GU19161@hoeg.nl> References: <20090226020330.GC25211@citylink.fud.org.nz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TYoqghpzCwoKvQG2" Content-Disposition: inline In-Reply-To: <20090226020330.GC25211@citylink.fud.org.nz> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: usb@freebsd.org, current@freebsd.org, Hans Petter Selasky Subject: Re: USB devfs patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 08:45:31 -0000 --TYoqghpzCwoKvQG2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Andrew, * Andrew Thompson wrote: > Below is a patch from Rink Springer to change the new USB stack to use > devfs device nodes. I have tested this with a usb mouse and I am hoping > people with other devices can test too, in particular scanners (sane > app) and lpt ports. I also mentioned this on IRC, but just to make sure it won't get lost. I really like the patch. I just tried it and it seems to work as advertised. What's your opinion on this patch? http://80386.nl/pub/usb-cdev.diff It turns the d_fdopen() function to a regular d_open(). I think we should only use d_fdopen() in cases where we really need access to the file descriptor (like ptmx). --=20 Ed Schouten WWW: http://80386.nl/ --TYoqghpzCwoKvQG2 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkmmVqgACgkQ52SDGA2eCwXQ7ACeJHtydVjx6ylLmo4RVdz5qVHj BxIAn2jPaDObeUql6QV6wMDaGL1s1Sph =ft0H -----END PGP SIGNATURE----- --TYoqghpzCwoKvQG2--