From nobody Fri Jan 26 02:10:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TLh4S731lz58Vj0; Fri, 26 Jan 2024 02:10:48 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TLh4S5LDwz4CV5; Fri, 26 Jan 2024 02:10:48 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-55a356f8440so8805031a12.2; Thu, 25 Jan 2024 18:10:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706235046; x=1706839846; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vnwdALbbBh9HDDVtSO4B403CHLEg0otgMFCMRkAn9Z0=; b=DypA8x5gES2O0iRwUleNk56Y2jMi9ZLcKC1k4bu1frDXrCzL6+XctBCcaNMqpsyghU /rPPj3tTFHZyBDUCx/3TCOXh6GztXmQq4zKveqTk8WpMSrVLebEAC2rc926/K0OvftfN eTFUDHiSkWtIJjIY6TBVprdoWqdbKCeqRcJ4fu4uFvLOFtptxQ5eeQl/f8vwnlrJYWWd rkINnRiEcspVtgUqNPXj9jJap0ko7W5QHxYaV1qS5OP36VuO6BfD2WjWXVSojnLPPFc/ jtGJe5Z4VowpHJbhLrb5K+CIHCki7V9RgmkJjzqU31GJB3dApLh0dOSD9kV+ZOJBDKT+ KHJg== X-Gm-Message-State: AOJu0Yw4kudtVhts3oJRPG1BlbQa9Hwaj1r+DZY5whIWU+E2bgnaZe1C AogvpIxJTXBy0Q+k8muQB166T8ApWYYXdksczE/ByK5ojx6ULSzsTpIh9R3EyTnWAzpdRywnjj3 hLFFl1/6lKZ/b44JDTcCc6uKZDaJC2lq5 X-Google-Smtp-Source: AGHT+IGkZkOsvsCQnVKOfC5vO8MTRFdH/vuoR2+2ceTXWMIB89Kf4q1b40r6G5tKAGB2VDp/gQGOiKCkIzWA8nYg9WU= X-Received: by 2002:a05:6402:1a3a:b0:55a:ccda:76b1 with SMTP id be26-20020a0564021a3a00b0055accda76b1mr571384edb.13.1706235045850; Thu, 25 Jan 2024 18:10:45 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202401260202.40Q22Lg7066965@gitrepo.freebsd.org> In-Reply-To: <202401260202.40Q22Lg7066965@gitrepo.freebsd.org> From: "Jason E. Hale" Date: Thu, 25 Jan 2024 21:10:34 -0500 Message-ID: Subject: Re: git: 824cdca032f1 - main - audio/strawberry: Add gstreamer plugins To: Kevin Bowling Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4TLh4S5LDwz4CV5 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] On Thu, Jan 25, 2024 at 9:02=E2=80=AFPM Kevin Bowling wrote: > > The branch main has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D824cdca032f1fc8a7f02ddc8= 108a1340c7772af9 > > commit 824cdca032f1fc8a7f02ddc8108a1340c7772af9 > Author: Kevin Bowling > AuthorDate: 2024-01-26 02:00:06 +0000 > Commit: Kevin Bowling > CommitDate: 2024-01-26 02:00:06 +0000 > > audio/strawberry: Add gstreamer plugins > > Without these, the software is not useful and requires extra work. > There are probably some better tradeoffs, but ship the default set fr= om > the older Clementine port until proven otherwise. > > PR: 276488 > Approved by: maintainer > --- > audio/strawberry/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/audio/strawberry/Makefile b/audio/strawberry/Makefile > index fbdc4b4c3e7c..3ebea3e26936 100644 > --- a/audio/strawberry/Makefile > +++ b/audio/strawberry/Makefile > @@ -69,6 +69,7 @@ EBUR128_IMPLIES=3D GSTREAMER > > GSTREAMER_USES=3D gstreamer > GSTREAMER_CMAKE_BOOL=3D ENABLE_GSTREAMER > +GSTREAMER_USE=3D GSTREAMER=3Dcdparanoia,chromaprint,faac,faad,fl= ac,lame,mpg123,neon,opus,shout2,soup,taglib,twolame,vorbis > > ICONV_USES=3D iconv:translit > I actually did not approve this and even mentioned in the PR that many of these plugins are superfluous and that the cdparanoia plugin is only useful for the CDIO option. - Jason