From owner-freebsd-smp Wed Oct 4 0: 0: 8 2000 Delivered-To: freebsd-smp@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id A192737B503 for ; Tue, 3 Oct 2000 23:59:57 -0700 (PDT) Received: (qmail 12263 invoked from network); 4 Oct 2000 06:59:53 -0000 Received: from unknown (HELO bde.zeta.org.au) (203.2.228.102) by gidora.zeta.org.au with SMTP; 4 Oct 2000 06:59:53 -0000 Date: Wed, 4 Oct 2000 17:59:49 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: John Baldwin Cc: Steve Kargl , freebsd-smp@FreeBSD.ORG, Jake Burkholder Subject: Re: witness code status? In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, 3 Oct 2000, John Baldwin wrote: > On 03-Oct-00 Steve Kargl wrote: > > John Baldwin wrote: > >> > >> On 03-Oct-00 Jake Burkholder wrote: > >> > Attached is a patch that should fix this. > >> > Please let me know and I'll commit it. (Works here.) > >> > >> Ugh. How and why does this work exactly, and should we be > >> #include'ing opt_user_ldt.h in an include file instead, or > >> should we move USER_LDT to opt_global.h perhaps? > >> > > > > Well, it appears to work because > > troutmask:sgk[247] find /sys/ -name \*.h | xargs grep USER_LDT > > /sys/compile/TROUTMASK/opt_user_ldt.h:#define USER_LDT 1 > > /sys/i386/include/globaldata.h:#ifdef USER_LDT > > /sys/i386/include/globals.h:#ifdef USER_LDT > > /sys/i386/include/globals.h:#ifdef USER_LDT > > Argh. Ok. In some other header files we create dummy variables > so that the structs remain the same. > > > And kern_idle.c includes > > > >#include > >#include > > > > which suggests that yes USER_LDT should move to opt_global.h. No, it suggests another broken header and/or an #include mess. MI code cannot reference MD variables (global or otherwise) directly. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message