Date: Wed, 4 Oct 2000 17:59:49 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.ORG> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>, freebsd-smp@FreeBSD.ORG, Jake Burkholder <jburkhol@home.com> Subject: Re: witness code status? Message-ID: <Pine.BSF.4.21.0010041749470.10616-100000@besplex.bde.org> In-Reply-To: <XFMail.001003121907.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 3 Oct 2000, John Baldwin wrote: > On 03-Oct-00 Steve Kargl wrote: > > John Baldwin wrote: > >> > >> On 03-Oct-00 Jake Burkholder wrote: > >> > Attached is a patch that should fix this. > >> > Please let me know and I'll commit it. (Works here.) > >> > >> Ugh. How and why does this work exactly, and should we be > >> #include'ing opt_user_ldt.h in an include file instead, or > >> should we move USER_LDT to opt_global.h perhaps? > >> > > > > Well, it appears to work because > > troutmask:sgk[247] find /sys/ -name \*.h | xargs grep USER_LDT > > /sys/compile/TROUTMASK/opt_user_ldt.h:#define USER_LDT 1 > > /sys/i386/include/globaldata.h:#ifdef USER_LDT > > /sys/i386/include/globals.h:#ifdef USER_LDT > > /sys/i386/include/globals.h:#ifdef USER_LDT > > Argh. Ok. In some other header files we create dummy variables > so that the structs remain the same. > > > And kern_idle.c includes > > > >#include <machine/globaldata.h> > >#include <machine/globals.h> > > > > which suggests that yes USER_LDT should move to opt_global.h. No, it suggests another broken header and/or an #include mess. MI code cannot reference MD variables (global or otherwise) directly. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0010041749470.10616-100000>