From owner-freebsd-sparc64@FreeBSD.ORG Thu Jan 8 09:03:35 2004 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 320EB16A4CE for ; Thu, 8 Jan 2004 09:03:35 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id D105E43D7E for ; Thu, 8 Jan 2004 09:03:31 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id C19905C746; Thu, 8 Jan 2004 09:03:31 -0800 (PST) Date: Thu, 8 Jan 2004 18:03:31 +0100 From: Maxime Henrion To: Marius Strobl Message-ID: <20040108170331.GW2060@elvis.mu.org> References: <20040108094116.GU2060@elvis.mu.org> <20040108175835.A95298@newtrinity.zeist.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040108175835.A95298@newtrinity.zeist.de> User-Agent: Mutt/1.4.1i cc: sparc64@freebsd.org Subject: Re: Need testers for patch to get MAC address of integrated dc(4) cards X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2004 17:03:35 -0000 Marius Strobl wrote: > On Thu, Jan 08, 2004 at 10:41:16AM +0100, Maxime Henrion wrote: > > Hi all, > > > > > > > > I've tweaked Marius' patch to properly get the MAC address of the > > integrated Davicom cards found in some sparc64 boxes from OpenFirmware > > without breaking the build of the dc(4) module. I'd like to get this > > tested as soon as possible because this patch should go into 5.2-RELEASE > > and we don't have much time left. Since I don't have the necessary > > hardware to test it myself, I need your help guys :-). > > > > For what it's worth, putting the code into an OF_getetheraddr2() > > function is a bit crude, but since Marius experienced difficulties > > merging it into OF_getetheraddr(), I chose to stay on the safe side. > > This can be revisited later. > > > > Please use the attached version instead, it has two changes over Maxime's > version: > - Fix compilation by adding a prototype for OF_getetheraddr2(). Hmm, yes, I had this in my tree of course but forgot to include it in the patch. > - Add a debugging printf for an issue I had with my version of > OF_getetheraddr() to really make sure it works as expected. I guess that could be useful. Cheers, Maxime