Date: Thu, 29 May 2014 10:40:48 -0400 From: Jason Hellenthal <jhellenthal@dataix.net> To: Kevin Lo <kevlo@FreeBSD.org> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, "adrian@freebsd.org" <adrian@freebsd.org>, "\[FreeBSD Stable\]" <freebsd-stable@freebsd.org>, "jhb@freebsd.org" <jhb@freebsd.org> Subject: Re: [VIMAGE][udplite] FreeBSD 10-STABLE/powerpc Message-ID: <FE10C0AD-D0B9-4CE3-BFA7-45F5383E5E65@dataix.net> In-Reply-To: <20140529083619.GA8437@ns.kevlo.org> References: <CAO2cuEPMy6KfeVj9O22fn3%2BM5P%2BFWaaO%2BcLHud9HGd%2Br-L2J%2Bg@mail.gmail.com> <20140529083619.GA8437@ns.kevlo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi Kevin,
Default on PowerPC is GCC 4.2.1
Its hard to see that this wouldn't turn up elsewhere on other arch' stop though as from what I seen doesn't seem to be dependent on PowerPC alone.
But to confirm my previous build, after backing out udplite the build did complete just fine. I'll find out in a little while whether it runs :-) crossing fingers.
--
Jason Hellenthal
Voice: 95.30.17.6/616
JJH48-ARIN
> On May 29, 2014, at 4:36, Kevin Lo <kevlo@FreeBSD.org> wrote:
>
>> On Thu, May 29, 2014 at 02:34:47AM -0400, Jason Hellenthal wrote:
>> Is anyone aware that VIMAGE on powerpc is currently broken ?
>
> Hi Jason,
>
> Did you mean that compile VIMAGE support into your kernel will fail?
> If so, what compiler do you use? Thanks.
>
>>
>> In file included from /export/usr/src/sys/netinet/in_proto.c:83:
>> /export/usr/src/sys/netinet/udp_var.h: In function 'get_inpcbinfo':
>> /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to
>> incomplete type
>> /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to
>> incomplete type
>> /export/usr/src/sys/netinet/udp_var.h: In function 'get_pcblist':
>> /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to
>> incomplete type
>> /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to
>> incomplete type
>> *** Error code 1
>>
>> The relevant code in that header is:
>> get_inpcbinfo(uint8_t protocol)
>> {
>> return (protocol == IPPROTO_UDP) ? &V_udbinfo : &V_ulitecbinfo;
>> }
>>
>> get_pcblist(uint8_t protocol)
>> {
>> return (protocol == IPPROTO_UDP) ? &V_udb : &V_ulitecb;
>> }
>>
>> Working Copy Root Path: /usr/src
>> URL: svn://svn.freebsd.org/base/stable/10
>> Relative URL: ^/stable/10
>> Repository Root: svn://svn.freebsd.org/base
>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
>> Revision: 266818
>> Node Kind: directory
>> Schedule: normal
>> Last Changed Author: delphij
>> Last Changed Rev: 266816
>> Last Changed Date: 2014-05-28 14:51:49 -0400 (Wed, 28 May 2014)
>>
>> Also looking at svn it appears to have come from this commit... I have
>> backed out the change here and it appears to be following through so more
>> attention to VIMAGE and udplite seems to be needed.
>>
>> ------------------------------------------------------------------------
>> r265946 | kevlo | 2014-05-13 02:05:53 -0400 (Tue, 13 May 2014) | 14 lines
>> Changed paths:
>> M /stable/10
>> M /stable/10/lib/libc/net/getaddrinfo.c
>> M /stable/10/sys/netinet/in.c
>> M /stable/10/sys/netinet/in.h
>> M /stable/10/sys/netinet/in_pcb.c
>> M /stable/10/sys/netinet/in_proto.c
>> M /stable/10/sys/netinet/udp_usrreq.c
>> M /stable/10/sys/netinet/udp_var.h
>> A /stable/10/sys/netinet/udplite.h (from
>> /head/sys/netinet/udplite.h:264212)
>> M /stable/10/sys/netinet6/in6_ifattach.c
>> M /stable/10/sys/netinet6/in6_proto.c
>> M /stable/10/sys/netinet6/udp6_usrreq.c
>> M /stable/10/sys/netinet6/udp6_var.h
>> M /stable/10/sys/sys/param.h
>>
>> MFC r264212,r264213,r264248,r265776,r265811,r265909:
>>
>> - Add support for UDP-Lite protocol (RFC 3828) to IPv4 and IPv6 stacks.
>> Tested with vlc and a test suite [1].
>> [1] http://www.erg.abdn.ac.uk/~gerrit/udp-lite/files/udplite_linux.tar.gz
>>
>> Reviewed by: jhb, glebius, adrian
>>
>> - Fix a logic bug which prevented the sending of UDP packet with 0 checksum.
>>
>> - Disable TX checksum offload for UDP-Lite completely. It wasn't used for
>> partial checksum coverage, but even for full checksum coverage it doesn't
>> work.
>>
>> ------------------------------------------------------------------------
>
> Kevin
[-- Attachment #2 --]
0 *H
010 + 0 *H
90000
*H
010 UIL10U
StartCom Ltd.1+0)U"Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0
130518085048Z
140519220947Z0H10Ujhellenthal@dataix.net1%0# *H
jhellenthal@dataix.net0"0
*H
0
'`TmfkܨJ5u+c'Upb`zv)&ȸXZ*VN6JvLoVoh}g
pQDŽKf/tZA˳("4Ԅ˻'d2h|IBl'^v^;'e8S99ۿVm|k8_UQtC"5l!kjZ]އQGn\Bh!FTsD%pV^Eӑd¨x"9
г"f 00 U0 0U0U%0++0UڔfmVʢ$䟓0U#0Sr풜\|~5NԸQ0!U0jhellenthal@dataix.net0LU C0?0;+70*0.+"http://www.startssl.com/policy.pdf0+00' StartCom Certification Authority0This certificate was issued according to the Class 1 Validation requirements of the StartCom CA policy, reliance only for the intended purpose in compliance of the relying party obligations.06U/0-0+)'%http://crl.startssl.com/crtu1-crl.crl0+009+0-http://ocsp.startssl.com/sub/class1/client/ca0B+06http://aia.startssl.com/certs/sub.class1.client.ca.crt0#U0http://www.startssl.com/0
*H
{0Ӹ,52W{Ey8b[{7 _+P"n["-,@ŽpJ-W$ݍjWA-6z( RdIZ.KzXє[K6}{s+v.Qh0PͅKhTw 0I73lz*Kv4Kkگ63;p1:ױ@)]ok>:W%XwC1þL/o8~#oP0400
*H
0}10 UIL10U
StartCom Ltd.1+0)U"Secure Digital Certificate Signing1)0'U StartCom Certification Authority0
071024210155Z
171024210155Z010 UIL10U
StartCom Ltd.1+0)U"Secure Digital Certificate Signing1806U/StartCom Class 1 Primary Intermediate Client CA0"0
*H
0
-).2AUGo#G
B|NDRpM-B=o-we5JQpa>O.#._<V
[~**pz~3WG .ᘟMlr[<Ce6fqO"uxfWN#uicgkv$Lb%y`_{`xK'GN 00U00U0USr풜\|~5NԸQ0U#0N@[i04hCA0f+Z0X0'+0http://ocsp.startssl.com/ca0-+0!http://www.startssl.com/sfsca.crt0[UT0R0'%#!http://www.startssl.com/sfsca.crl0'%#!http://crl.startssl.com/sfsca.crl0U y0w0u+70f0.+"http://www.startssl.com/policy.pdf04+(http://www.startssl.com/intermediate.pdf0
*H
}x,\c^#wMq}>UK/^yX֏y frMIŲB61ymQҨݬZ0&