From owner-freebsd-arch Thu Jan 31 18:33:39 2002 Delivered-To: freebsd-arch@freebsd.org Received: from falcon.prod.itd.earthlink.net (falcon.mail.pas.earthlink.net [207.217.120.74]) by hub.freebsd.org (Postfix) with ESMTP id 293D537B404 for ; Thu, 31 Jan 2002 18:33:21 -0800 (PST) Received: from pool0359.cvx40-bradley.dialup.earthlink.net ([216.244.43.104] helo=mindspring.com) by falcon.prod.itd.earthlink.net with esmtp (Exim 3.33 #1) id 16WTVZ-0000Vq-00; Thu, 31 Jan 2002 18:32:57 -0800 Message-ID: <3C59FAFA.1EE9B153@mindspring.com> Date: Thu, 31 Jan 2002 18:18:34 -0800 From: Terry Lambert X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: "M. Warner Losh" Cc: drosih@rpi.edu, Todd.Miller@courtesan.com, perry@wasabisystems.com, wes@softweyr.com, asmodai@wxs.nl, mckusick@mckusick.com, arch@FreeBSD.ORG, peter@wemm.org, phk@critter.freebsd.dk, deatley@apple.com, jkh@winston.freebsd.org, deraadt@cvs.openbsd.org Subject: Re: __P macro question References: <87d6zq31z6.fsf@snark.piermont.com> <200201312043.g0VKhrDx004889@xerxes.courtesan.com> <20020131.153607.63055791.imp@village.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "M. Warner Losh" wrote: > : static int sendfile __P((struct printer *pp, int type, char *file, > : int format)); > : > : for a procedure declaration of: > : static int > : sendfile(pp, type, file, format) > : struct printer *pp; > : int type; > : char *file; > : char format; > : { > > That's *EXCATLY* why I'm converting the old, but still legal in c89, > style to new style. You get warnings that you didn't get before. The compiler is broken, if it accepts the second when the first prototype is in scope. It's a broken compiler, period. Conversion doesn't fix the compiler brokeness. I thought you were just getting rid of __P()? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message