Date: Fri, 11 Dec 2015 14:42:05 -0500 From: Michael McConville <mmcco@mykolab.com> To: freebsd-current@freebsd.org Subject: XOR pt. 2 Message-ID: <20151211194204.GA26628@thinkpad.swarthmore.edu>
next in thread | raw e-mail | index | archive | help
Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR
cleanly in the current if-else condition, but I'm not sure whether that
was intended. I just wanted to pass this by people in case it was a
logical bug.
--- dev/ixgb/if_ixgb.c.orig
+++ dev/ixgb/if_ixgb.c
@@ -599,10 +599,7 @@ ixgb_ioctl(struct ifnet * ifp, IOCTL_CMD
}
#endif /* DEVICE_POLLING */
if (mask & IFCAP_HWCSUM) {
- if (IFCAP_HWCSUM & ifp->if_capenable)
- ifp->if_capenable &= ~IFCAP_HWCSUM;
- else
- ifp->if_capenable |= IFCAP_HWCSUM;
+ ifp->if_capenable ^= IFCAP_HWCSUM;
if (ifp->if_drv_flags & IFF_DRV_RUNNING)
ixgb_init(adapter);
}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151211194204.GA26628>