Date: Wed, 04 Sep 2013 14:38:16 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@FreeBSD.org> Cc: svn-src-head@freebsd.org, Xin LI <delphij@freebsd.org>, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@freebsd.org> Subject: Re: svn commit: r255152 - head/sys/dev/atkbdc Message-ID: <52277E18.2000908@FreeBSD.org> In-Reply-To: <52277838.1030102@FreeBSD.org> References: <201309021825.r82IPIwi046033@svn.freebsd.org> <522636EA.3010509@delphij.net> <5226E777.4000909@FreeBSD.org> <52277276.9050206@delphij.net> <52277838.1030102@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------070302030305030702060505
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2013-09-04 14:13:12 -0400, Jung-uk Kim wrote:
> On 2013-09-04 13:48:38 -0400, Xin Li wrote:
>> Hi,
>
>> On 09/04/13 00:55, Jean-Sébastien Pédron wrote:
>>> On 03.09.2013 21:22, Xin Li wrote:
>>>> I think this broke my ThinkPad T530, the system appears like
>>>> that the click button is "sticky" (not quite sure what's
>>>> happening though, key combos like Alt+Tab won't work).
>
>>> After a quick search, it seems this laptop has a Trackpoint,
>>> not a Synaptics touchpad, as I assumed. Therefore, you don't
>>> need to try to revert the commits I mentioned.
>
>>> Instead, can you just set the trackpoint_support tunable to 0,
>>> not the Synaptics one, to see if it isolates the issue?
>
>> With the following:
>
>> #hw.psm.synaptics_support=0 hw.psm.trackpoint_support=0
>
>> I am still able to reproduce the issue. It seems like if I
>> "swipe" my finger on the touchpad, I can recover from the
>> situation.
>
> Please revert r255152. synaptics_support was turned off by
> default because its probing method is too intrusive, i.e., it
> affects other mice/touchpads. trackpoint_support is still
> experimental.
Or maybe the attached patch is enough, I am not sure.
Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iQEcBAEBAgAGBQJSJ34YAAoJECXpabHZMqHO3W8H/3lBm1q0ZeLfUQRNW+saP+AX
0buoXnmIeLlrrBYnvkwx6YDsm6jNWifUncGeIEePBwpe6X1McMizGtw0vrHiWSq0
ZlYnAOmUmjPDfLk6LG7oyZIlDsOsuY2wSCuXphDyzJh/A4xy81pYAwxqpTE3QXq1
O6yPqCJHNbFNt7X6vpN4UQmPbMU6RRxXnIedswsBK0eUn74I0b9DV8fV5MsIstIw
n3XOjbEh55bxbqF1bFz7tS9YkkRVctYCDVoHw2+szAI/NV4uNjD/Ciydj+6ktiBc
VDcksZ7fIhWMvA3jNLl1TWCGjuE7KHuKuF6SPBfZb0T9tQMPvZ7N3Di0coB8/hw=
=hBv2
-----END PGP SIGNATURE-----
--------------070302030305030702060505
Content-Type: text/x-patch;
name="psm.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename="psm.diff"
Index: /usr/src/sys/dev/atkbdc/psm.c
===================================================================
--- /usr/src/sys/dev/atkbdc/psm.c (revision 255209)
+++ /usr/src/sys/dev/atkbdc/psm.c (working copy)
@@ -494,6 +494,8 @@ static struct {
0x08, MOUSE_4D_PACKETSIZE, enable_4dmouse },
{ MOUSE_MODEL_4DPLUS, /* A4 Tech 4D+ Mouse */
0xc8, MOUSE_4DPLUS_PACKETSIZE, enable_4dplus },
+ { MOUSE_MODEL_TRACKPOINT, /* IBM/Lenovo TrackPoint */
+ 0xc0, MOUSE_PS2_PACKETSIZE, enable_trackpoint },
{ MOUSE_MODEL_SYNAPTICS, /* Synaptics Touchpad */
0xc0, MOUSE_SYNAPTICS_PACKETSIZE, enable_synaptics },
{ MOUSE_MODEL_INTELLI, /* Microsoft IntelliMouse */
@@ -504,8 +506,6 @@ static struct {
0x80, MOUSE_PS2_PACKETSIZE, enable_kmouse },
{ MOUSE_MODEL_VERSAPAD, /* Interlink electronics VersaPad */
0xe8, MOUSE_PS2VERSA_PACKETSIZE, enable_versapad },
- { MOUSE_MODEL_TRACKPOINT, /* IBM/Lenovo TrackPoint */
- 0xc0, MOUSE_PS2_PACKETSIZE, enable_trackpoint },
{ MOUSE_MODEL_GENERIC,
0xc0, MOUSE_PS2_PACKETSIZE, NULL },
};
--------------070302030305030702060505--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52277E18.2000908>