From owner-svn-src-stable-10@freebsd.org Mon Dec 19 17:02:33 2016 Return-Path: Delivered-To: svn-src-stable-10@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A73E3C884CB; Mon, 19 Dec 2016 17:02:33 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7D8D3106C; Mon, 19 Dec 2016 17:02:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id D6B4E10A761; Mon, 19 Dec 2016 12:02:24 -0500 (EST) From: John Baldwin To: Andriy Gapon Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts Date: Mon, 19 Dec 2016 08:55:26 -0800 Message-ID: <2547422.gn4y6NaJ31@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <912ba7fd-353c-006e-ef65-faa12b83de9f@FreeBSD.org> References: <201611061356.uA6DuYcO079294@repo.freebsd.org> <1625245.4edrXav981@ralph.baldwin.cx> <912ba7fd-353c-006e-ef65-faa12b83de9f@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 19 Dec 2016 12:02:24 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 17:02:33 -0000 On Wednesday, December 14, 2016 05:41:47 PM Andriy Gapon wrote: > On 05/12/2016 23:49, John Baldwin wrote: > > On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote: > >> Author: avg > >> Date: Sun Nov 6 13:56:34 2016 > >> New Revision: 308371 > >> URL: https://svnweb.freebsd.org/changeset/base/308371 > >> > >> Log: > >> MFC r307768: jedec_ts: a driver for thermal sensors on memory modules > >> > >> Added: > >> stable/10/share/man/man4/jedec_ts.4 > >> - copied unchanged from r307768, head/share/man/man4/jedec_ts.4 > >> stable/10/sys/dev/jedec_ts/ > >> - copied from r307768, head/sys/dev/jedec_ts/ > >> stable/10/sys/modules/i2c/jedec_ts/ > >> - copied from r307768, head/sys/modules/i2c/jedec_ts/ > >> Modified: > >> stable/10/sys/conf/NOTES > >> stable/10/sys/conf/files > >> stable/10/sys/modules/i2c/Makefile > >> Directory Properties: > >> stable/10/ (props changed) > > > > FYI, this doesn't work and has broken tinderbox builds on stable/10. > > smbus_get_addr() doesn't exist on 10. It was originally a hand-rolled > > ivar wrapper that was removed in r93023 in 2002. The function prototype > > was not removed, so the compile works, but linking fails. The stale > > prototype is still present in smbconf.h in HEAD (and should be removed). > > The "real" smbus_get_addr() was added back to smbconf.h along with an > > implementation of smbus_read_ivar() in r281985. Parts of that commit > > probably need to be MFC'd to 10. > > > > John, > > thank you for catching this and sorry for the trouble. > Could you please check if r310062 really fixes the problem? Yes. Well, it fixes linking of kernels at least. Now make tinderbox on 10 fails for the following kernels: _.ia64.GENERIC: Maxmem is not available on ia64. It is spelled paddr_max instead. The firewire code is trying to use Maxmem. _.ia64.LINT: Same. _.arm.LINT: Many link errors and warnings, though lack of 'kbd_*' symbols seems to be the only actual errors. I suspect you recently MFC'd changes to fwohci.c that are using Maxmem. However, I'm not sure it is worth fixing fwohci on ia64. -- John Baldwin