From owner-freebsd-apache@FreeBSD.ORG Tue Jun 10 18:48:01 2014 Return-Path: Delivered-To: apache@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E6480FC7 for ; Tue, 10 Jun 2014 18:48:01 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 802A4261E for ; Tue, 10 Jun 2014 18:48:00 +0000 (UTC) Received: from [192.168.0.100] ([87.139.233.65]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MKHtm-1WsmvQ21ry-001eMC; Tue, 10 Jun 2014 20:47:58 +0200 Message-ID: <539752DE.5060208@gmx.de> Date: Tue, 10 Jun 2014 20:47:58 +0200 From: olli hauer User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Kurt Jaeger Subject: Re: www/p5-libapreq2: libtool fix, strip libs, pkg-plist followup, p5-fix References: <20140608081334.GK1427@f10.opsec.eu> <20140608083407.GL1427@f10.opsec.eu> <20140608083636.GM1427@f10.opsec.eu> <20140608085842.GO1427@f10.opsec.eu> <53945E98.3080408@gmx.de> <20140610094949.GY3484@f10.opsec.eu> In-Reply-To: <20140610094949.GY3484@f10.opsec.eu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:fk3UDl1JSHxMplGlCSjyxUQKJ0bxcA951282y8a1O6iJ2eqYrYE Yl5lPiRYM9IV5XzLXMrpo7Q5UsfwXJpmR7CCyXyzlNVeWYR9TFWggporpkNueq38sA7ojiu 00+v3q4KqOUjMrbTkGHSDi2klFQRE0rVMEYy4J9JDYkGaaQnYtn3v2F8q+/hPA5CkVkd6no bJPoLaAAA11UlTPGCvKGA== Cc: Frederic Culot , apache@freebsd.org, skv@FreeBSD.org X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2014 18:48:02 -0000 On 2014-06-10 11:49, Kurt Jaeger wrote: > Hi! > > Back to my proposed change for www/libapreq2 and this question: > >>> Would it be more useful to make the slave port (p5-libapreq2) >>> a seperate port depending on the other ? > > Looking at the pkg-plist and Makefile mess: Is it really useful > to have this master/slave port or should I split and depend on libapreq2 ? > I suspect this port will never win a pretty contest ... running a short grep over the tree shows there are only two libapreq2 consumers - www/mod_amazon_proxy - www/p5-libapreq2 but eleven p5-libapreq consumers - net-mgmt/netdisco - net-mgmt/netdot - www/foswiki-ModPerlEngineContrib - www/p5-Apache-Gallery - www/p5-Apache2-SiteControl - www/p5-CGI-Application-Plugin-Apache - www/p5-HTML-Mason - www/p5-Maypole - www/rt38 - www/rt40.cpan - www/rt42.cpan The line WITH_MODPERL2 is from history where apache13 / mod_perl was also in the tree (WITH_MODPERL) (w.o 2) Since WITH_MODPERL2 is only defined in libapreq2, p5-libapreq2 it can be replaced without any side effects to reflect p5-libapreq2. Splitting the port is maybe easier with two pkg-plists. One part slipped over my last mail and should be fixed in the final commit post-stage: -+ ${STRIP_CMD}·${STAGEDIR}/usr/local/lib/libapreq2.so.3.8.0 -+ ${STRIP_CMD}·${STAGEDIR}/usr/local/libexec/apache22/mod_apreq2.so ++ ${STRIP_CMD}·${STAGEDIR}${PREFIX}//lib/libapreq2.so.3.8.0 ++ ${STRIP_CMD}·${STAGEDIR}${PREFIX}/${APACHEMODDIR}/mod_apreq2.so -- Regards, olli