From owner-freebsd-fs@FreeBSD.ORG  Mon Dec 31 16:25:55 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 by hub.freebsd.org (Postfix) with ESMTP id 955076B7;
 Mon, 31 Dec 2012 16:25:55 +0000 (UTC)
 (envelope-from mjguzik@gmail.com)
Received: from mail-wi0-x22a.google.com (mail-wi0-x22a.google.com
 [IPv6:2a00:1450:400c:c05::22a])
 by mx1.freebsd.org (Postfix) with ESMTP id CC9A08FC0A;
 Mon, 31 Dec 2012 16:25:54 +0000 (UTC)
Received: by mail-wi0-f170.google.com with SMTP id hq7so6339249wib.5
 for <multiple recipients>; Mon, 31 Dec 2012 08:25:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:date:from:to:cc:subject:message-id:references
 :mime-version:content-type:content-disposition:in-reply-to
 :user-agent; bh=V/OTS8E4ZOQ035pvlktNg6jh7cFwYBMSIlnsyHZDK30=;
 b=OB7GHf3rC6vIyrHC5vxuaCudp8T8Nm8G5yX24Ab+KkpNJCQUMpSDuUMplceunDyyPZ
 F5nY706MvtSlCXXR/dnFedqQZ+HzBBUBojk5Rbn3XuWgMSxJAT0NWRjCL8h67XkksVxd
 Mo3OySnpedpo/GUSp7pX+7Ik2tIaoqIHUNhFPiv3pXDxm3pyjRNqwI3d9ukhcndHdKga
 /m3Qqm2XPrrASFox/h13sTSWwvp1FG7PgIA/jOKi/UFbBFNwE00KjRwtr9yh/inUqJxS
 UxJ2aLIoT119UwIGIQwN/tlkWKWmUQz8Y+IB3mehcOSXRzOkATb851P6sNXYz8HpHADi
 pctg==
X-Received: by 10.194.171.198 with SMTP id aw6mr51312634wjc.3.1356971154057;
 Mon, 31 Dec 2012 08:25:54 -0800 (PST)
Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net.
 [2001:470:1f08:1f7::2])
 by mx.google.com with ESMTPS id hu8sm54275058wib.6.2012.12.31.08.25.51
 (version=TLSv1/SSLv3 cipher=OTHER);
 Mon, 31 Dec 2012 08:25:53 -0800 (PST)
Date: Mon, 31 Dec 2012 17:25:40 +0100
From: Mateusz Guzik <mjguzik@gmail.com>
To: Ronald Klop <ronald-freebsd8@klop.yi.org>
Subject: Re: Nandfs use of MNT_VNODE_FOREACH
Message-ID: <20121231162540.GB29588@dft-labs.eu>
References: <20121227230223.GN82219@kib.kiev.ua>
 <op.wp6d7vdo8527sy@212-182-167-131.ip.telfort.nl>
 <20121231162145.GA29588@dft-labs.eu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20121231162145.GA29588@dft-labs.eu>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: gber@freebsd.org, cognet@freebsd.org, fs@freebsd.org
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2012 16:25:55 -0000

On Mon, Dec 31, 2012 at 05:21:45PM +0100, Mateusz Guzik wrote:
> Can you adjust this function so that 'if (mp->mnt_syncer == vp)'
> performs VI_UNLOCK as well?
> 
> Something like:
> if (mp->mnt_syncer == vp || VOP_ISLOCKED(vp)) {
> 	VI_UNLOCK(mp);
> 	continue;
> }
> 
> I will have time to dig into this next week.

Err.. I meant VI_UNLOCK(vp).

-- 
Mateusz Guzik <mjguzik gmail.com>