From nobody Mon Oct 27 16:17:55 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwJZb16VLz6F0GY; Mon, 27 Oct 2025 16:17:59 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwJZZ1Vbjz4JK1; Mon, 27 Oct 2025 16:17:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004b.ext.cloudfilter.net ([10.228.9.230]) by cmsmtp with ESMTPS id DJzJv8eHpAPFJDPuuvp569; Mon, 27 Oct 2025 16:17:56 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id DPutvkUIGE9qcDPuuv1S5p; Mon, 27 Oct 2025 16:17:56 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=fPU0HJae c=1 sm=1 tr=0 ts=68ff9b34 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=x6icFKpwvdMA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=A-PQIV8mPBIpMYVP9AcA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 1DD26474; Mon, 27 Oct 2025 09:17:55 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 0D67A40B; Mon, 27 Oct 2025 09:17:55 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: jlduran@freebsd.org cc: Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 79e374217d69 - main - blocklist: Fix rcorder(8) In-reply-to: References: <202510271547.59RFlnxW096622@gitrepo.freebsd.org> <20251027155808.A4532201@slippy.cwsent.com> Comments: In-reply-to Jose Luis Duran message dated "Mon, 27 Oct 2025 13:04:16 -0300." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 27 Oct 2025 09:17:55 -0700 Message-Id: <20251027161755.0D67A40B@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLtP/WrunG3iadahmpykhYIrlWGOunY4DlqLTPAw3PfVBKCIgMVhuTBuTdmToh76jYgnkLJV4zD2A0D5ruMurncyKaw0+sRI4gP/MMsX5Gv46FJT+sPp vKwObe++jT9kZGT1FV13zwzqqdsgAjoUJezvEfLcq1X2WilC0peH7RzI1xGUf2RbZXdDEvHQOUqTAVL3AMNs+6M5sMNSJXi9jPnImHnbrYoQQVROQTPDsspa Cy8AneBOnYgSCHMlzq7YNjhmxRNX4j1hLvytB7aJGbYT9M6E77LjTSEoWoh6THCjUhV1teL25wwr6EyZnGAsWD52FDBpRoBrMJIG2Bmjb2I= X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cwJZZ1Vbjz4JK1 In message , Jose Luis Duran writes: > On Mon, Oct 27, 2025 at 12:58=E2=80=AFPM Cy Schubert .com> wrote: > > > > In message <202510271547.59RFlnxW096622@gitrepo.freebsd.org>, Jose Luis > > Duran w > > rites: > > > The branch main has been updated by jlduran: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D79e374217d69a98161fc91a2= > 86dacf1f > > > 78090894 > > > > > > commit 79e374217d69a98161fc91a286dacf1f78090894 > > > Author: Jose Luis Duran > > > AuthorDate: 2025-10-27 15:46:32 +0000 > > > Commit: Jose Luis Duran > > > CommitDate: 2025-10-27 15:46:32 +0000 > > > > > > blocklist: Fix rcorder(8) > > > > > > The blocklist daemon depends on a packet filter in order to block. > > > > > > Add all supported packet filters to the REQUIRE line, not just pf, = > to > > > indicate rcorder(8) that it should start after the packet filter se= > rvice > > > has started. > > > > > > While here, change the mode of the rc file to include the executabl= > e > > > bit, just like the rest of the files in the rc.d source directory. > > > > > > Reviewed by: 0mp > > > MFC after: 2 days > > > Differential Revision: https://reviews.freebsd.org/D53364 > > > --- > > > libexec/rc/rc.d/blacklistd | 2 +- > > > libexec/rc/rc.d/blocklistd | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/libexec/rc/rc.d/blacklistd b/libexec/rc/rc.d/blacklistd > > > index 9157e258f43f..175e3e8c56b3 100755 > > > --- a/libexec/rc/rc.d/blacklistd > > > +++ b/libexec/rc/rc.d/blacklistd > > > @@ -29,7 +29,7 @@ > > > # > > > > > > # PROVIDE: blacklistd > > > -# REQUIRE: netif pf > > > +# REQUIRE: netif ipfilter ipfw pf > > > > This means all three, ipfilter AND ipfw AND pf, must be enabled and > > started. What if one uses only one of the three? > > No, per rcorder(8) BUGS section: > > The REQUIRE keyword is misleading: > It does not describe which daemons have to be running before a script > will be started. > It describes which scripts must be placed before it in the dependency order= > ing. > > 0mp@ even suggests creating a FIREWALL(S) script to represent that an > rc script should start after the firewall (any one or many) has > started. I agree, but I cannot immediately submit a patch for it. I stand corrected. Thanks. > > > > > > > . /etc/rc.subr > > > > > > diff --git a/libexec/rc/rc.d/blocklistd b/libexec/rc/rc.d/blocklistd > > > old mode 100644 > > > new mode 100755 > > > index 24cbae77fd40..f979162ec3e0 > > > --- a/libexec/rc/rc.d/blocklistd > > > +++ b/libexec/rc/rc.d/blocklistd > > > @@ -29,7 +29,7 @@ > > > # > > > > > > # PROVIDE: blocklistd > > > -# REQUIRE: netif pf > > > +# REQUIRE: netif ipfilter ipfw pf > > > > Ditto. > > > > > > > > . /etc/rc.subr > > > > > > > > > > > > -- > > Cheers, > > Cy Schubert > > FreeBSD UNIX: Web: https://FreeBSD.org > > NTP: Web: https://nwtime.org > > > > e**(i*pi)+1=3D0 > > > > > > > --=20 > Jose Luis Duran -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0