Date: Tue, 12 Feb 2019 09:25:30 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Dmitry Morozovsky <marck@freebsd.org>, Cy Schubert <Cy.Schubert@cschubert.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r344051 - in stable/12/sbin: newfs tunefs Message-ID: <CANCZdfoghrVR3uMQM3oqzv31g732iOHJP=iEeO2qD8kbgUwVrw@mail.gmail.com> In-Reply-To: <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net> References: <alpine.BSF.2.00.1902121808080.2716@woozle.rinet.ru> <201902121621.x1CGL5dq076678@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 12, 2019 at 9:21 AM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Tue, 12 Feb 2019, Cy Schubert wrote: > > > > > In message <201902121358.x1CDwGf9047873@repo.freebsd.org>, Dmitry > > > Morozovsky wr > > > ites: > > > > Author: marck (doc committer) > > > > Date: Tue Feb 12 13:58:16 2019 > > > > New Revision: 344051 > > > > URL: https://svnweb.freebsd.org/changeset/base/344051 > > > > > > > > Log: > > > > MFC 343548: > > > > > > > > Allow dashes as a valid character in UFS labels. > > > > > > Approved by: Whom? > > > > Sorry, I missed commit log metadata from the original change. > > > > Lesson learnt. > > I think your fine on how you did this, I certainly already > knew from reading the ^head commits that this change had > infact been approved by Kirk, and had been flagged for MFC. > > I do not see value in duplicationg all that info in the > stable branches, but perhaps we should formalize that in > the committers guide on commit messages? > Let's not overreact. Someone made a commit, someone else didn't go check the original commit to see it was legit and asked a question. The original bonafides were provided. Case closed. No need to make a federal case out of it. The doc committer learned to take a little extra care on their commit messages, it seems, as doc committers committing to src get a little extra scrutiny. The original complainer likely noticed the info was in the original commit and may check there in the future before complaining. Or maybe he won't. It isn't a big deal either way. None of this requires a change to the rules. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoghrVR3uMQM3oqzv31g732iOHJP=iEeO2qD8kbgUwVrw>