Date: Mon, 5 Jul 2021 09:08:15 +0200 From: =?UTF-8?Q?Lo=c3=afc_Bartoletti?= <lbartoletti@FreeBSD.org> To: Christoph Moench-Tegeder <cmt@burggraben.net> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: be86c4fe23e0 - main - misc/qtchooser: remove Message-ID: <2569fab0-d643-e22a-0d3a-2e4df497c75f@FreeBSD.org> In-Reply-To: <YOIoFS9WMLRdgUhk@elch.exwg.net> References: <202107041732.164HW8HQ076467@gitrepo.freebsd.org> <YOIoFS9WMLRdgUhk@elch.exwg.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hello, Le 04/07/2021 à 23:28, Christoph Moench-Tegeder a écrit : > ## Loïc Bartoletti (lbartoletti@FreeBSD.org): > This: > >> misc/qtchooser: remove > Does more than it says on the label: Indeed, removing a tool like this one cannot be done without patching (many) other ports. > >> --- a/cad/freecad/Makefile >> +++ b/cad/freecad/Makefile >> -USES= dos2unix compiler:c++11-lib cmake gl eigen:3 fortran jpeg \ >> +USES= dos2unix compiler:c++17-lang cmake gl eigen:3 fortran jpeg \ >> + -DBUILD_ENABLE_CXX_STD=C++17 Sorry, this line is not needed to build cad/freecad without qtchooser. I added it during my tests, because I saw that it was necessary to reduce some warnings, but it's not useful for this change. > I'd appricate knowing why these additional changes happen - it reduces > annoyances on my side when these changes interfere with other patches > I've lined up (yeah, I should just commit faster, but sometimes live > happens). We have communicated in the past, publicly or directly with those affected, like you, for this kind of improvement. Although this initiative has been public for several months, it may not have been visible. I will ensure better communication for the next times. Regards, Loïc > > Regards, > Christoph >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2569fab0-d643-e22a-0d3a-2e4df497c75f>