From owner-svn-src-head@FreeBSD.ORG Wed Jul 1 13:58:07 2009 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04B1B106566C; Wed, 1 Jul 2009 13:58:07 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au [211.29.132.188]) by mx1.freebsd.org (Postfix) with ESMTP id 746BB8FC1A; Wed, 1 Jul 2009 13:58:06 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from besplex.bde.org (c122-106-161-96.carlnfd1.nsw.optusnet.com.au [122.106.161.96]) by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id n61DvY9g025213 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 1 Jul 2009 23:57:35 +1000 Date: Wed, 1 Jul 2009 23:57:34 +1000 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Maxim Konovalov In-Reply-To: <20090701152300.N96900@mp2.macomnet.net> Message-ID: <20090701234518.E2035@besplex.bde.org> References: <200906230555.n5N5tubJ065618@svn.freebsd.org> <20090623080015.GK48776@hoeg.nl> <20090623125125.F1156@mp2.macomnet.net> <86ljn923dw.fsf@ds4.des.no> <20090701152300.N96900@mp2.macomnet.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Ed Schouten Subject: Re: svn commit: r194681 - head/usr.sbin/wpa/ndis_events X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 13:58:07 -0000 On Wed, 1 Jul 2009, Maxim Konovalov wrote: > On Tue, 30 Jun 2009, 16:38+0200, Dag-Erling Smrgrav wrote: > >> Maxim Konovalov writes: >>> fixed, thanks. >> >> It still says >> >> static void >> usage() >> >> I know this is allowed by C99, but it's not allowed by style(9). >> > From style(9): > > static void > usage() > { > /* Insert an empty line if the function has no local variables. */ > ... > > Apart from the empty line, what's wrong? style(9) hasn't been converted to its own religion yet :-). This isn't exactly a bug, since an old-style Standard C function definition is still Normal for usage(). Normal file order is a prototype for usage(), then main() calling usage(), then usage(), so a separate prototype for usage() is Normal. Then usage an old-style definition for usage() breaks K&R support without affecting Standard C support. Bruce