From owner-svn-src-all@freebsd.org  Mon Nov  7 18:22:20 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E795C35F62;
 Mon,  7 Nov 2016 18:22:20 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CF859CE2;
 Mon,  7 Nov 2016 18:22:19 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id D23961FE022;
 Mon,  7 Nov 2016 19:22:17 +0100 (CET)
Subject: Re: svn commit: r308424 - head/sys/arm/broadcom/bcm2835
To: Oleksandr Tymoshenko <gonzo@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201611071738.uA7HceYu045944@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <f8169b11-56d8-4566-f9e9-e387dd9b939e@selasky.org>
Date: Mon, 7 Nov 2016 19:27:28 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <201611071738.uA7HceYu045944@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Nov 2016 18:22:20 -0000

On 11/07/16 18:38, Oleksandr Tymoshenko wrote:
> +		bcm2835_audio_unlock(sc);
> +		cv_signal(&sc->worker_cv);


Shouldn't cv_signal() be done locked, so that you don't loose any 
transactions? CV's only wakeup the treads that are sleeping right there 
and then.

--HPS