From owner-freebsd-current@freebsd.org Sun Jul 22 22:33:39 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 399F1103139E for ; Sun, 22 Jul 2018 22:33:39 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C62B78877A for ; Sun, 22 Jul 2018 22:33:38 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7FD961031396; Sun, 22 Jul 2018 22:33:38 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B9AE1031391 for ; Sun, 22 Jul 2018 22:33:38 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE57688778; Sun, 22 Jul 2018 22:33:37 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-wr1-f68.google.com with SMTP id c13-v6so16065316wrt.1; Sun, 22 Jul 2018 15:33:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qTR99K/2LcK6bAeeoPVOCA6IUqXtnUXqkcduU3Cq8Pc=; b=RA/gCApEJLVTMwj2vxxQ6wvWiOyJAqmN4sFE//WhMiQgIJZi5nmuzTzR2wrIBbOj+t Ocx/Kj36gsTFS7vLEs2beAduhf9oyePYzg/OU2RsYGZsgUiAthOpRNVuu/Ar0aF5jZc5 A+ZuLJs9DQh0vBMWqMMk7oMRHHO/U9zpVSiCK5vOwtG10fOeIxicatJLKQhETjlFEkh4 Ct1eCzkZUzXtqnNEKW7SRldmt4tCuyXg4VdRmtQevqRNh/GOooQnXronG7/ExmC53JU1 3Azym3FWKoa5eglHv7INw2ygnAPtmLZRVeYuu9t+JOb+rwR90h6qQGFtPbGVzetmmqCr Ud9A== X-Gm-Message-State: AOUpUlGeBweKrVe9hM7e5BaDtHiZDedJwRnwUBq7zNEIym61adAOPN6H BytVJYakrMTUyu+Qcn+36FfGOySeYA+dH3QruhcK2w== X-Google-Smtp-Source: AAOMgpfX/1TzdtligvXz/ddZ4gwLPsvqlTb+6Hum9Q6hZL8oNyfFJsZTfYHde88mxrn5KYfteO108aYSO5xOdPw5mms= X-Received: by 2002:adf:e190:: with SMTP id k16-v6mr6816863wri.36.1532295560296; Sun, 22 Jul 2018 14:39:20 -0700 (PDT) MIME-Version: 1.0 References: <941706773.1.1532139392496.JavaMail.jenkins@jenkins.ci.freebsd.org> <20180721231832.GC65334@kib.kiev.ua> <20180722010116.GA13419@freefall.freebsd.org> <20180722154505.GE65334@kib.kiev.ua> <20180722171601.GA25771@x1c.lwhsu.org> <20180722212655.GF65334@kib.kiev.ua> In-Reply-To: <20180722212655.GF65334@kib.kiev.ua> From: Li-Wen Hsu Date: Sun, 22 Jul 2018 22:39:08 +0100 Message-ID: Subject: Re: FreeBSD-head-riscv64-build - Build #9623 (r336573) - Failure To: Konstantin Belousov Cc: current@freebsd.org, Ruslan Bukin Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2018 22:33:39 -0000 On Sun, Jul 22, 2018 at 10:27 PM Konstantin Belousov wrote: > > On Sun, Jul 22, 2018 at 06:16:02PM +0100, Li-Wen Hsu wrote: > > On Sun, Jul 22, 2018 at 18:45:05 +0300, Konstantin Belousov wrote: > > > On Sun, Jul 22, 2018 at 01:01:16AM +0000, Li-Wen Hsu wrote: > > > Well, the arch(7) manpage documents __riscv__. Compilers typically > > > provide both __XXX__ and __XXX, while FreeBSD traditionally uses > > > the __XXX__ form. > > > > Please check r322168, __riscv__ is replaced by __riscv and > > __riscv64 is replaced by (__riscv && __riscv_xlen == 64). Details are > > in the commit message. > > > > Alghough I grep'd sys/ and there are some __riscv__ still existing: > > > > sys/vm/vm_unix.c:72:#if !defined(__aarch64__) && !defined(__riscv__) > > sys/vm/vm_unix.c:81:#else /* defined(__aarch64__) || defined(__riscv__) */ > > sys/vm/vm_unix.c:83:#endif /* defined(__aarch64__) || defined(__riscv__) */ > > > > I guess those also need changing, as well as arch(7) > > > > > > > With that change, I think that your patch should go in regardless of > > > the second issue below. > > > > Thanks, please commit or approve it. > Why do you need an approval ? I already said that your patch looks fine. Oh, I did not realize that means a green light. Also I am not sure about your opinion of __riscv and __riscv__. Does my original patch look OK to you? -- Li-Wen Hsu https://lwhsu.org