From nobody Wed Sep 22 08:28:43 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D2DF317D63F4 for ; Wed, 22 Sep 2021 08:28:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HDrzb5SpMz4Ztt for ; Wed, 22 Sep 2021 08:28:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9BE0014643 for ; Wed, 22 Sep 2021 08:28:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 18M8ShDG065408 for ; Wed, 22 Sep 2021 08:28:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 18M8ShUt065407 for ports-bugs@FreeBSD.org; Wed, 22 Sep 2021 08:28:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 258631] dns/opendnssec2: Update to 2.1.10 Date: Wed, 22 Sep 2021 08:28:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eduardo@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258631 --- Comment #4 from Nuno Teixeira --- (In reply to Jaap Akkerhuis from comment #2) Remember that portlint, portclippy and portfmt are tools that we do not hav= e to follow blindly like any other tool. 1. portlint: OK 2. portclippy Makefile: --- # PORTNAME block PORTNAME DISTVERSION CATEGORIES MASTER_SITES PKGNAMESUFFIX # Maintainer block MAINTAINER COMMENT # License block LICENSE LICENSE_FILE # Dependencies BUILD_DEPENDS LIB_DEPENDS # USES block USES USE_RC_SUBR # Configure block GNU_CONFIGURE CONFIGURE_ARGS # Make block +INSTALL_TARGET -SUB_FILES # Conflicts CONFLICTS # Standard bsd.port.mk variables +SUB_FILES # Users and groups block USERS GROUPS # Options definitions OPTIONS_DEFINE OPTIONS_DEFAULT -OPTIONS_SUB OPTIONS_SINGLE OPTIONS_SINGLE_DB +OPTIONS_SUB # Options descriptions +MYSQL_DESC SOFTHSM_DESC -MYSQL_DESC SQLITE_DESC # Options helpers +MYSQL_USES MYSQL_CONFIGURE_ON +SOFTHSM_RUN_DEPENDS +SOFTHSM_CONFIGURE_ON +SQLITE_BUILD_DEPENDS -MYSQL_USES SQLITE_USES SQLITE_CONFIGURE_ON -SQLITE_BUILD_DEPENDS -SOFTHSM_CONFIGURE_ON -SOFTHSM_RUN_DEPENDS -INSTALL_TARGET --- Seems fine to me this changes 3. portfmt -D Makefile: --- --- Makefile +++ Makefile @@ -31,23 +31,22 @@ GROUPS=3D opendnssec PORTDOCS=3D MIGRATION NEWS README.md -MIGRATE=3D README.md find_problematic_zones.sql \ - convert_mysql mysql_convert.sql \ - convert_sqlite sqlite_convert.sql +MIGRATE=3D README.md find_problematic_zones.sql convert_mysql \ + mysql_convert.sql convert_sqlite sqlite_convert.sql CONVERT=3D convert_mysql_to_sqlite convert_sqlite_to_mysql SCHEMAS=3D schema.mysql schema.sqlite -OPTIONS_DEFINE=3D SOFTHSM DOCS +OPTIONS_DEFINE=3D DOCS SOFTHSM OPTIONS_DEFAULT=3D SQLITE OPTIONS_SUB=3D yes OPTIONS_SINGLE=3D DB -OPTIONS_SINGLE_DB=3D SQLITE MYSQL +OPTIONS_SINGLE_DB=3D MYSQL SQLITE -SOFTHSM_DESC=3D SoftHSM cryptographic store for PKCS \#11 interfa= ce +SOFTHSM_DESC=3D SoftHSM cryptographic store for PKCS \#11 interface -MYSQL_DESC=3D Use MYSQL backend -SQLITE_DESC=3D Use SQLite backend +MYSQL_DESC=3D Use MYSQL backend +SQLITE_DESC=3D Use SQLite backend MYSQL_CONFIGURE_ON=3D --with-enforcer-database=3Dmysql MYSQL_USES=3D mysql @@ -59,7 +58,7 @@ SOFTHSM_CONFIGURE_ON=3D=20 --with-pkcs11-softhsm=3D${LOCALBASE}/lib/softhsm/libsofthsm2.so SOFTHSM_RUN_DEPENDS=3D softhsm2>=3D2.5.0:security/softhsm2 -INSTALL_TARGET=3D install-strip +INSTALL_TARGET=3D install-strip pre-build: ${REINPLACE_CMD} -e "s|\(-lcrypto\)|-L${OPENSSLLIB} \1|g" \ --- - MIGRATE part is ok with better look at 72 columns - OPTIONS_DEFINE is ok with alphabetical order - OPTIONS_SINGLE_DB is ok with alphabetical order - TABS are optional portfmt is a bit tricky and I always be carefull with this tool. Cheers --=20 You are receiving this mail because: You are the assignee for the bug.=