Date: Wed, 22 Sep 2021 08:28:43 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 258631] dns/opendnssec2: Update to 2.1.10 Message-ID: <bug-258631-7788-8oE7cU1h7u@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-258631-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-258631-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258631 --- Comment #4 from Nuno Teixeira <eduardo@FreeBSD.org> --- (In reply to Jaap Akkerhuis from comment #2) Remember that portlint, portclippy and portfmt are tools that we do not hav= e to follow blindly like any other tool. 1. portlint: OK 2. portclippy Makefile: --- # PORTNAME block PORTNAME DISTVERSION CATEGORIES MASTER_SITES PKGNAMESUFFIX # Maintainer block MAINTAINER COMMENT # License block LICENSE LICENSE_FILE # Dependencies BUILD_DEPENDS LIB_DEPENDS # USES block USES USE_RC_SUBR # Configure block GNU_CONFIGURE CONFIGURE_ARGS # Make block +INSTALL_TARGET -SUB_FILES # Conflicts CONFLICTS # Standard bsd.port.mk variables +SUB_FILES # Users and groups block USERS GROUPS # Options definitions OPTIONS_DEFINE OPTIONS_DEFAULT -OPTIONS_SUB OPTIONS_SINGLE OPTIONS_SINGLE_DB +OPTIONS_SUB # Options descriptions +MYSQL_DESC SOFTHSM_DESC -MYSQL_DESC SQLITE_DESC # Options helpers +MYSQL_USES MYSQL_CONFIGURE_ON +SOFTHSM_RUN_DEPENDS +SOFTHSM_CONFIGURE_ON +SQLITE_BUILD_DEPENDS -MYSQL_USES SQLITE_USES SQLITE_CONFIGURE_ON -SQLITE_BUILD_DEPENDS -SOFTHSM_CONFIGURE_ON -SOFTHSM_RUN_DEPENDS -INSTALL_TARGET --- Seems fine to me this changes 3. portfmt -D Makefile: --- --- Makefile +++ Makefile @@ -31,23 +31,22 @@ GROUPS=3D opendnssec PORTDOCS=3D MIGRATION NEWS README.md -MIGRATE=3D README.md find_problematic_zones.sql \ - convert_mysql mysql_convert.sql \ - convert_sqlite sqlite_convert.sql +MIGRATE=3D README.md find_problematic_zones.sql convert_mysql \ + mysql_convert.sql convert_sqlite sqlite_convert.sql CONVERT=3D convert_mysql_to_sqlite convert_sqlite_to_mysql SCHEMAS=3D schema.mysql schema.sqlite -OPTIONS_DEFINE=3D SOFTHSM DOCS +OPTIONS_DEFINE=3D DOCS SOFTHSM OPTIONS_DEFAULT=3D SQLITE OPTIONS_SUB=3D yes OPTIONS_SINGLE=3D DB -OPTIONS_SINGLE_DB=3D SQLITE MYSQL +OPTIONS_SINGLE_DB=3D MYSQL SQLITE -SOFTHSM_DESC=3D SoftHSM cryptographic store for PKCS \#11 interfa= ce +SOFTHSM_DESC=3D SoftHSM cryptographic store for PKCS \#11 interface -MYSQL_DESC=3D Use MYSQL backend -SQLITE_DESC=3D Use SQLite backend +MYSQL_DESC=3D Use MYSQL backend +SQLITE_DESC=3D Use SQLite backend MYSQL_CONFIGURE_ON=3D --with-enforcer-database=3Dmysql MYSQL_USES=3D mysql @@ -59,7 +58,7 @@ SOFTHSM_CONFIGURE_ON=3D=20 --with-pkcs11-softhsm=3D${LOCALBASE}/lib/softhsm/libsofthsm2.so SOFTHSM_RUN_DEPENDS=3D softhsm2>=3D2.5.0:security/softhsm2 -INSTALL_TARGET=3D install-strip +INSTALL_TARGET=3D install-strip pre-build: ${REINPLACE_CMD} -e "s|\(-lcrypto\)|-L${OPENSSLLIB} \1|g" \ --- - MIGRATE part is ok with better look at 72 columns - OPTIONS_DEFINE is ok with alphabetical order - OPTIONS_SINGLE_DB is ok with alphabetical order - TABS are optional portfmt is a bit tricky and I always be carefull with this tool. Cheers --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-258631-7788-8oE7cU1h7u>