From owner-cvs-all Tue Nov 6 6:34:23 2001 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id D31CC37B405; Tue, 6 Nov 2001 06:34:14 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id 4702414C40; Tue, 6 Nov 2001 15:34:13 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: Jeroen Ruigrok/Asmodai Cc: "Andrew R. Reiter" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/syscons/logo logo_saver.c src/sys/dev/syscons/rain rain_saver.c src/sys/dev/syscons/warp warp_saver.c References: <20011106102215.J97551@daemon.ninth-circle.org> <20011106105256.K97551@daemon.ninth-circle.org> From: Dag-Erling Smorgrav Date: 06 Nov 2001 15:34:12 +0100 In-Reply-To: <20011106105256.K97551@daemon.ninth-circle.org> Message-ID: Lines: 15 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jeroen Ruigrok/Asmodai writes: > -On [20011106 10:50], Dag-Erling Smorgrav (des@ofug.org) wrote: > > Read code first, ask questions later. > If you can give me 48 hours in a day to spend time to read all the code > people commit then yes, otherwise I resort to asking questions to the > person who just touched the code, one could assume they are now probably > more familiar with it then the person asking the question. Just pointing out once more that people should refrain from criticizing commit messages when they're not familiar with the affected subsystem and haven't read the diffs. DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message