From owner-freebsd-bugs  Fri Oct 20  8:30:10 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id C8F0B37B4D7
	for <freebsd-bugs@FreeBSD.org>; Fri, 20 Oct 2000 08:30:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id IAA36358;
	Fri, 20 Oct 2000 08:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from qwerty.eunet.ch (qwerty.eunet.ch [146.228.11.110])
	by hub.freebsd.org (Postfix) with ESMTP id 16B5437B4E5
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 20 Oct 2000 08:23:31 -0700 (PDT)
Received: (from bs@localhost)
	by qwerty.eunet.ch (8.9.3/8.9.3) id RAA53304;
	Fri, 20 Oct 2000 17:23:26 +0200 (CEST)
	(envelope-from bs)
Message-Id: <200010201523.RAA53304@qwerty.eunet.ch>
Date: Fri, 20 Oct 2000 17:23:26 +0200 (CEST)
From: Bernard Steiner <bs@qwerty.eunet.ch>
Reply-To: bs@qwerty.eunet.ch
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/22152: typo in ip_fw.c
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         22152
>Category:       kern
>Synopsis:       typo in ip_fw.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 20 08:30:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Bernard Steiner
>Release:        FreeBSD 4.1-RELEASE i386
>Organization:
KPNQwest Switzerland Ltd
>Environment:

	

>Description:

	
/sys/netinet/ip_fw.c about line 175 in 4.1R, 4.1.1R
(and possibly 5.0 current ?) contain the line

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
/*  --------------------------------------^^^^^ */
    &dyn_rst_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^ */

which I believe makes the dynamic ruleset time out pre-maturely.


>How-To-Repeat:

	

>Fix:

	

Looks like a cut-and-paste typo to me. I suggest:

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
    &dyn_short_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^^^ */

but please do check that I am not mistaken :-)

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message